[nrf noup] subsys/fs: move FS partition to the end back #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
btw, |
|
All checks are passing now. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
nvlsianpu
force-pushed
the
partittion-backward-com
branch
from
892b9ff to
151007e
Compare
|
How can we avoid similar problems affecting users during the 1.2 -> 1.3 transition? |
|
This stuff should have been picked up by our DFU tests, not sure why they were not. @mbolivar I will make sure that we add backwards compatible tests to ensure that this does not happen again. As for products in field, they will use static configuration, so there is no risk of bricking a configuration so that you are not able to produce valid updates once a device is out. |
hakonfam
reviewed
Apr 15, 2020
Awesome, thanks! |
In case of the DFU capability enabled: Up to NCS v1.1.0 any storage partition lands at the end of the flash memory. Since v1.2.0 any storage partition lands right after the executable application. So it is impossible to build proper update application out-of-the box. This patch moves storage partitions at the flash end back. User needs only to correct the partition size (via Kconfig) to the same as in previous release for ensure proper upgrade build. Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
nvlsianpu
force-pushed
the
partittion-backward-com
branch
from
151007e to
1e802ec
Compare
hakonfam
approved these changes
Apr 16, 2020
|
ping @mbolivar @sigvartmh |
mbolivar-nordic
approved these changes
Apr 20, 2020
|
DNM until Upmerge #296 will be merged |
sigvartmh
approved these changes
Apr 30, 2020
|
moved to nrfconnect/sdk-nrf#2382 |
Damian-Nordic
added a commit
to Damian-Nordic/sdk-zephyr
that referenced
this pull request
May 15, 2025
…nect#293 Pull in clang compilation error fix. Upstream PR #: 89989 Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
Damian-Nordic
added a commit
to Damian-Nordic/sdk-zephyr
that referenced
this pull request
May 15, 2025
…nect#293 Pull in clang compilation error fix. Upstream PR #: 89989 Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
rlubos
pushed a commit
that referenced
this pull request
May 15, 2025
Pull in clang compilation error fix. Upstream PR #: 89989 Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
rlubos
added a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Jun 2, 2025
…nrfconnect#293" This reverts commit b1c7699. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
added a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Jun 2, 2025
…nrfconnect#293" This reverts commit b1c7699. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
added a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Jun 2, 2025
…nrfconnect#293" This reverts commit b1c7699. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
added a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Jun 2, 2025
…nrfconnect#293" This reverts commit b1c7699. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
added a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Jun 3, 2025
…nrfconnect#293" This reverts commit b1c7699. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
added a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Jun 3, 2025
…nrfconnect#293" This reverts commit b1c7699. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
added a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Jun 3, 2025
…nrfconnect#293" This reverts commit b1c7699. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
added a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Jun 4, 2025
…nrfconnect#293" This reverts commit b1c7699. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
added a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Jun 5, 2025
…nrfconnect#293" This reverts commit b1c7699. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
added a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Jun 5, 2025
…nrfconnect#293" This reverts commit b1c7699. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
added a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Jun 5, 2025
…nrfconnect#293" This reverts commit b1c7699. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
added a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Jun 6, 2025
…nrfconnect#293" This reverts commit b1c7699. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
added a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Jun 6, 2025
…nrfconnect#293" This reverts commit b1c7699. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
added a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Jun 6, 2025
…nrfconnect#293" This reverts commit b1c7699. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
added a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Jun 11, 2025
…nrfconnect#293" This reverts commit b1c7699. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
added a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Jun 11, 2025
…nrfconnect#293" This reverts commit b1c7699. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
added a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Jun 11, 2025
…nrfconnect#293" This reverts commit b1c7699. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
added a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Jun 11, 2025
…nrfconnect#293" This reverts commit b1c7699. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
added a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Jun 11, 2025
…nrfconnect#293" This reverts commit b1c7699. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
added a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Jun 12, 2025
…nrfconnect#293" This reverts commit b1c7699. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
added a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Jun 12, 2025
…nrfconnect#293" This reverts commit b1c7699. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
added a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Jun 12, 2025
…nrfconnect#293" This reverts commit b1c7699. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
added a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Jun 12, 2025
…nrfconnect#293" This reverts commit b1c7699. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
added a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Jun 12, 2025
…nrfconnect#293" This reverts commit b1c7699. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
added a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Jun 13, 2025
…nrfconnect#293" This reverts commit b1c7699. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
added a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Jun 13, 2025
…nrfconnect#293" This reverts commit b1c7699. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
added a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Jun 13, 2025
…nrfconnect#293" This reverts commit b1c7699. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
added a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Jun 13, 2025
…nrfconnect#293" This reverts commit b1c7699. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
added a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Jun 16, 2025
…nrfconnect#293" This reverts commit b1c7699. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of the DFU capability enabled:
Up to NCS v1.1.0 any storage partition lands at the end of the flash memory.
Since v1.2.0 any storage partition lands right after
the executable application.
So it is impossible to build proper update application out-of-the box.
This patch moves storage partitions at the flash end back.
User needs only to correct the partition size (via Kconfig) to
the same as in previous release for ensure proper upgrade build.
Signed-off-by: Andrzej Puzdrowski andrzej.puzdrowski@nordicsemi.no