[Do Not Review ] Data pool size reduction #2699
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling This is no longer necessary, because thanks to sysbuild we no longer invoke a runner with a .hex file that is the result of merging builds for more than one core. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no> (cherry picked from commit aaefaad)
These are used to detect if the firmware image contains any values inside the UICR for additional handling. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no> (cherry picked from commit fa66984)
This is no longer used at all. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no> (cherry picked from commit 4e8ec16)
The `erase` command was being used but there was no "backend" implementation for it in nrfutil nor nrfjprog. Simplify the syntax and implement it for both tools. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no> (cherry picked from commit dc7d8bb)
…RF52 series The Nordic nRF52 series have a peculiarity that is not shared with any other Nordic families of SoCs: the reset pin can be reconfigured as a regular GPIO. This has an unintended consequence: if the user has reconfigured the pin in Devicetree to be a GPIO, `west flash` will override that and configure the IC to use it as a reset pin, and the firmware at boot won't be able to switch it back to GPIO, because that requires a UICR erase. This behavior is very confusing to users, because the GPIO does not work at all, since it is now just a reset line. With this patch, `west flash` defaults to using soft reset instead of pin reset for the nRF52 family of devices, to avoid overwriting the reset pin configuration that the user includes in the image. In order to be able to continue to use pin reset for users that so desire it, a new option `--pinreset` is added that forces the use of pin reset. The existing `--softreset` option is left exactly as it was, but it is now applicable only to families other than the nRF52. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no> (cherry picked from commit 17a671c)
- Allocate source in PBP first time adv is created - Only set_adv_data in adv_setup if ext_adv already exists - Fixes regression in PTS for PBP tests Signed-off-by: Alexander Svensen <alexander.svensen@nordicsemi.no> (cherry picked from commit 33b4fae) Signed-off-by: Alexander Svensen <alexander.svensen@nordicsemi.no>
…54H20 After commit aaefaad, flashing of the FLPR and PPR cores in the nRF54H20 was broken due to those cores missing from the _get_core() function that retrieves the core to program, triggering an exception. Fix it by referencing those cores and mapping them to the application core. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no> (cherry picked from commit 7254a61)
…nabled Set the default maximum argument count for the shell to 30 when the Wi-Fi shell is enabled, to ensure all Wi-Fi commands work without failure. Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no> (cherry picked from commit e7a65ac)
…thread Fixes overflow issue in the net_mgmt thread during network interface state changes. Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no> (cherry picked from commit 3a3f4ab)
Added Kconfig options to allow use of TWIM frequency workaround in NRFX for nRF52 and nRF53. Signed-off-by: Michał Stasiak <michal.stasiak@nordicsemi.no> (cherry picked from commit def5f8e)
… rates Add short transfer test at 8000, 16000, 32000, 44100, 48000, 88200 and 96000 frame clock frequency. Add KConfigs to skip test cases based on value of sample rate. Add configuration for nrf5340dk where i2s peripheral is clocked from ACLK. Signed-off-by: Sebastian Głąb <sebastian.glab@nordicsemi.no> (cherry picked from commit c42513a)
…n nrf54h20 Extend support in dt bindings and in the driver to allow use of AIN8 to AIN13 analog inputs. Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no> (cherry picked from commit f2e1ac0)
…onfiguration Add AIN9 pin in nrf54h20dk to verify AIN8-AIN13 inputs. Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no> (cherry picked from commit a5d023a)
…ection Selection of the LF clock source for the GRTC should be performed as early as possible, before starting GRTC. Upstream PR #: 87199 Signed-off-by: Adam Kondraciuk <adam.kondraciuk@nordicsemi.no>
…GRTC Disable automatic LFCLK selection for GRTC during driver initialization. For Zephyr applications it is selected by `sys_clock_driver_init()` depending on configuration and DTS. Upstream PR #: 87199 Signed-off-by: Adam Kondraciuk <adam.kondraciuk@nordicsemi.no>
Added configuration for new audio PLL service. Pull in new service implementation in new hal nordic. Signed-off-by: Łukasz Stępnicki <lukasz.stepnicki@nordicsemi.no> (cherry picked from commit 2bac5ee)
This fixes an issue where a subsequent Config Model Subscription Add message with the same virtual address UUID would result in a Config Model Subscription Status message with the Address field incorrectly set to 0. Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no> (cherry picked from commit d3997c6)
…fset The offset value in the PSA ITS non-volatile space is dedicated to OpenThread key reference IDs. This offset must not overwrite any other ranges already in use within the PSA ITS non-volatile space. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no> (cherry picked from commit ba9f627)
This reverts commit f1f6bc0. Signed-off-by: Théo Battrel <theo.battrel@nordicsemi.no>
The BLE acronym is not an official description of Bluetooth LE, and the Bluetooth SIG only ever refers to it as Bluetooth Low Energy or Bluetooth LE, so Zephyr should as well. This commit does not change any board or vendor specific documentation, and the term BLE may still be used in those. It will be up to the vendors to update it if they want, since many of them are using the term BLE in their products. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no> (cherry picked from commit 571f26c)
Update Kconfig options for qualification: - Remove experimental on qualified feature. - Add experimental on unqualified feature. - BT_L2CAP_ECRED is not marked as experimental upstream and we qualify it downstream. Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no> Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no> Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no> Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no> Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no> Signed-off-by: Ingar Kulbrandstad <ingar.kulbrandstad@nordicsemi.no> Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no> Signed-off-by: Herman Berget <herman.berget@nordicsemi.no> Signed-off-by: Tomasz Moń <tomasz.mon@nordicsemi.no> Signed-off-by: Théo Battrel <theo.battrel@nordicsemi.no> (cherry picked from commit e92e87d)
…PSA key IDs We need to make sure that within Zephyr different users of the PSA APIs don't interfere with each other because of using the same numerical IDs for persistent assets. This takes care of the PSA key IDs when using persistent keys through the PSA Crypto API. See the comments in `<zephyr/psa/key_ids.h>` for more information. This removes the recently-introduced Kconfig options that allowed changing the base IDs subsystems were using for their persistent keys. Signed-off-by: Tomi Fontanilles <tomi.fontanilles@nordicsemi.no> (cherry picked from commit 0c368e8)
…tions Commit removes weak attribute and renames some functions in crypto_psa.c since there is no centralized distribution of the PSA key ID in bsim tests and no necessity to reimplement native mesh approach. Signed-off-by: Aleksandr Khromykh <aleksandr.khromykh@nordicsemi.no> (cherry picked from commit acc752f)
Commit removes api prefix for static functions in crypto psa. Signed-off-by: Aleksandr Khromykh <aleksandr.khromykh@nordicsemi.no> (cherry picked from commit e075e08)
Commit removes centralized PSA key ID distribution in mesh bsim tests since secure storage is instantiated on every simulated device. Signed-off-by: Aleksandr Khromykh <aleksandr.khromykh@nordicsemi.no> (cherry picked from commit 6a9802e)
… runner is used The logic to detect the default JLink location was placed at the top of the script, executing whenever the script was imported. The west extension command framework loads all runners when initializing, and so this logic was being executed even when using another runner. Move the logic to a function that is only executed when the JLink runner is selected, to avoid executing it at all times. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no> (cherry picked from commit 4c12a8c)
…cutable Instead of hardcoding a set of paths and trying to find the JLink executable in them, use the corresponding Windows registry to locate it: `HKEY_CURRENT_USER\\Software\\SEGGER\\J-Link` Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no> (cherry picked from commit bb1794b)
During raw scan, Need to disable NRF_WIFI_MGMT_BUFF_OFFLOAD. UMAC will send beacon and probe responses directly to the host, regardless of the mgmt_buff_offload flag's value. Host needs to resubmit buffers to LMAC. Signed-off-by: Kapil Bhatt <kapil.bhatt@nordicsemi.no> (cherry picked from commit 1179014)
…uffers For different values of reorder buffer throughputs are consistent, Setting reorder buffer size to half of the RX buffers configured. Signed-off-by: Kapil Bhatt <kapil.bhatt@nordicsemi.no> (cherry picked from commit 9f7307f)
Add wifi_spi label to nRF54h and nRF54l dts files to help in shield overlay files Signed-off-by: Bansidhar P.M <bansidhar.mangalwedhekar@nordicsemi.no> (cherry picked from commit eb93df2)
Create dedicated memory pools for Wi-Fi management and data operations (defaults: 20KB for management and 130KB for data). Setting Data pool to 110KB for non-Nordic SOCs to resolve RAM overflows seen in twister runs. Remove the `HEAP_MEM_POOL_ADD_SIZE_NRF70` hint since we are creating separate heaps for driver and not allocating from system heap. Signed-off-by: Ravi Dondaputi <ravi.dondaputi@nordicsemi.no> (cherry picked from commit aa0cb68)
…ry pools Pull changes for creating separate memory pools for control traffic and data traffic. Signed-off-by: Ravi Dondaputi <ravi.dondaputi@nordicsemi.no> (cherry picked from commit 7f775c3)
With introduction of OSAL wrapper for memory allocation, usage of zephyr's native malloc calls need to be removed. When NRF70 driver is not enabled, OSAL needs to be built explicitly. Signed-off-by: Ravi Dondaputi <ravi.dondaputi@nordicsemi.no> (cherry picked from commit 208e686)
Some file names are changed, fix file names in doxygen comments. Signed-off-by: Kapil Bhatt <kapil.bhatt@nordicsemi.no> (cherry picked from commit 46829bb)
With recent code restructuring file name and path has been changed in nrf_wifi lib. Signed-off-by: Kapil Bhatt <kapil.bhatt@nordicsemi.no> (cherry picked from commit 9285344)
… info Pull in change to include reg chan info along with reg domain in the GET_REG_DOMAIN event for the radio test and offloaded raw TX modes. Signed-off-by: Sachin D Kulkarni <Sachin.Kulkarni@nordicsemi.no> (cherry picked from commit a34198b)
Pull in fix for CI failure in Offloaded raw TX mode caused due to commit 0cd3bb2291a7dd22f4cdb1a4cd935a213c2bbfab in nrf_wifi Signed-off-by: Sachin D Kulkarni <Sachin.Kulkarni@nordicsemi.no> (cherry picked from commit 69ce6af)
Add prompt to Kconfig NRF70_SYSTEM_WITH_RAW_MODES. It is assigned in a configuration file, but is not directly user-configurable (has no prompt). It gets its value indirectly from other symbols. Signed-off-by: Kapil Bhatt <kapil.bhatt@nordicsemi.no> (cherry picked from commit 3ef187d)
…ents Fix doxygen comments of arguments. Signed-off-by: Kapil Bhatt <kapil.bhatt@nordicsemi.no> (cherry picked from commit 5f3bd5d)
nRF70 driver now uses a separate heap, so, no need to explicitly configure the kernel heap. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no> (cherry picked from commit 0b8601c)
nRF70 now by default uses variale buffers. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no> (cherry picked from commit 8fe1df6)
Fine-tune the heap to get peak UDP (TX and RX) results but with minimal heap consumption. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no> (cherry picked from commit be4c79b)
This uses the network packet as is without the need for a copy all the way till the packet is handed over to RPU. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no> (cherry picked from commit 5119f9c)
Now that nRF70 by default uses zero-copy fine-tune the configuration to get optimal memory while getting peak throughputs. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no> (cherry picked from commit e33d9ee)
… address packets The RFC1122 section 3.3.6 says we SHOULD drop the packets if L2 address is brodcast but L3 address is unicast, but we had seen some Wi-Fi access points in the field not conforming to that, and DHCP offer is dropped due to this and causes Wi-Fi connectivity issues. As the RFC saus it's SHOULD and not a MUST, add a config option to allow such packets, disabled by default. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no> (cherry picked from commit 4cd6654)
Add new Ethernet driver config option, ETHERNET_CONFIG_TYPE_EXTRA_TX_PKT_HEADROOM, which allows Ethernet drivers to inform L2 about the extra net_pkt headroom they need to be allocated. This is only supported when CONFIG_NET_L2_ETHERNET_RESERVE_HEADER is enabled, so that it's possible to fit entire packet into a single net_buf, which is needed for zero-copy transmission. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no> (cherry picked from commit 78c3996)
It seems that this change was solely added to address issues with old TCP stack, which blindly queued packets intended for TX for potential further retransmission, expecting that the packet would remain intact during transmission. I think this assumption was wrong, as it's natural that lower layers append respective headers to the packet, and this "header stripping" behavior was specific for Ethernet L2 only. If an upper layer expects that the packet would need to be retransmitted at some point, it should clone it instead. Therefore, remove the L2 header stripping from the Ethernet L2 to avoid any potential issues in zero-copy case. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no> (cherry picked from commit 21b7122)
Fix linking errors by using the Zephyr flags for libary too. Upstream PR #: 87835 Signed-off-by: Kapil Bhatt <kapil.bhatt@nordicsemi.no>
…it failures Reconfigure DATA heap sizes to fix the driver init failures. Upstream PR #: 87979 Signed-off-by: Ravi Dondaputi <ravi.dondaputi@nordicsemi.no>
Add a debug shell to the driver to provide advanced debug support such as reading/writing to RPU memory and registers etc. Upstream PR #: 87823 Signed-off-by: Sachin D Kulkarni <Sachin.Kulkarni@nordicsemi.no>
Move the wifi_util to the newly created nrf70 shell as a sub-shell. Upstream PR #: 87823 Signed-off-by: Sachin D Kulkarni <Sachin.Kulkarni@nordicsemi.no>
Most samples may not need 130000 bytes for data plane operations. With STA sample, 40000 bytes have been established as enough for basic traffic. Reduce RX ring buffer size accordingly to 16. Signed-off-by: Ravi Dondaputi <ravi.dondaputi@nordicsemi.no>
|
The following west manifest projects have changed revision in this Pull Request:
Additional metadata changed:
⛔ DNM label due to: 1 project with metadata changes Note: This message is automatically posted and updated by the Manifest GitHub Action. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes on top of upmerge PR#2519