Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

applications: nrf5340_audio: Handle PD=0 in broadcast_sink #18091

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

applications: nrf5340_audio: Handle PD=0 in broadcast_sink #18091

wants to merge 1 commit into from
+2 −2

Conversation

alexsven
Copy link
Contributor

  • If presentation delay is set to 0, use the default and print a warning.
  • OCT-2952

@alexsven
applications: nrf5340_audio: Handle PD=0 in broadcast_sink
9425d86 
- If presentation delay is set to 0, use the default and
  print a warning.
- OCT-2952

Signed-off-by: Alexander Svensen <alexander.svensen@nordicsemi.no>
@alexsven alexsven requested a review from a team as a code owner October 22, 2024 12:15
@alexsven alexsven requested review from koffes, rick1082 and gWacey and removed request for a team October 22, 2024 12:15
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 22, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 22, 2024 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 1

Inputs:

Sources:

sdk-nrf: PR head: 9425d860a47fb751ee00d8b55ca87c5c9ff9ac91

more details

sdk-nrf:

PR head: 9425d860a47fb751ee00d8b55ca87c5c9ff9ac91
merge base: 17445fa164df6d009d43883985c41804128fcee1
target head (main): b993af99fe779f8f11172ad8c9c5667fa79e70cf
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (2) 
applications
│  ├── nrf5340_audio
│  │  ├── broadcast_sink
│  │  │  │ main.c
│  │  ├── src
│  │  │  ├── audio
│  │  │  │  │ audio_datapath.c

Outputs:

Toolchain

Version: 3dd8985b56
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:3dd8985b56_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 35
  • ✅ Integration tests
    • ✅ test-sdk-audio
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

koffes
koffes requested changes Oct 22, 2024
View reviewed changes
applications/nrf5340_audio/src/audio/audio_datapath.c
@@ -866,7 +866,8 @@ ZBUS_LISTENER_DEFINE(sdu_ref_msg_listen, audio_datapath_sdu_ref_update);
int audio_datapath_pres_delay_us_set(uint32_t delay_us)
{
if (!IN_RANGE(delay_us, CONFIG_AUDIO_MIN_PRES_DLY_US, CONFIG_AUDIO_MAX_PRES_DLY_US)) {
LOG_WRN("Presentation delay not supported: %d", delay_us);
LOG_WRN("Presentation delay not supported: %d us", delay_us);
LOG_WRN("Keeping current value: %d us", ctrl_blk.pres_comp.pres_delay_us);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are only log changes in this PR. No handling required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. Since the default is already used, and then you are not allowed to set PD=0 it will continue to use the default value. So I just removed the error print (as that would only be printed if someone attempts to set PD=0) and then printed what the default value is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koffes koffes koffes requested changes

@rick1082 rick1082 rick1082 approved these changes

@gWacey gWacey Awaiting requested review from gWacey gWacey is a code owner automatically assigned from nrfconnect/ncs-audio

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexsven @NordicBuilder @koffes @rick1082