-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samples: Add console suspend in system_off #18083
base: main
Are you sure you want to change the base?
Conversation
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 37781fe4c2f226cad54e2dea308f04d73cc9a084 more detailssdk-nrf:
Github labels
List of changed files detected by CI (4)
Outputs:ToolchainVersion: 3dd8985b56 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving a configuration-related suggestion.
CONFIG_ASSERT=n | ||
CONFIG_BT_ASSERT=n | ||
CONFIG_ASSERT_VERBOSE=n |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consider disabling CONFIG_NCS_SAMPLES_DEFAULTS
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you are disabling asserts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consider disabling
CONFIG_NCS_SAMPLES_DEFAULTS
?
Yes, I think we should disable CONFIG_NCS_SAMPLES_DEFAULTS
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you are disabling asserts?
I disabled asserts to reduce code and power consumption.
Added console suspend before `sys_poweroff` to reduce power usage. Ref: NCSDK-29688 Signed-off-by: Marcin Jelinski <marcin.jelinski@nordicsemi.no>
Added console suspend before `sys_poweroff` to reduce power usage. Ref: NCSDK-29688 Signed-off-by: Marcin Jelinski <marcin.jelinski@nordicsemi.no>
a690a71
to
37781fe
Compare
Added console suspend before
sys_poweroff
to reduce power usage inbluetooth: peripheral_power_profiling
andnfc: system_off
samples.