Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zigbee: fix issues with aborted FOTA downloads #14684

Merged
merged 3 commits into from
Apr 4, 2024
Merged

zigbee: fix issues with aborted FOTA downloads #14684

merged 3 commits into from
Apr 4, 2024

Conversation

edmont
Copy link
Contributor

@edmont edmont commented Apr 2, 2024

NCSIDB-1213

@edmont edmont requested a review from AdamZelikNS April 2, 2024 08:08
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Apr 2, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Apr 2, 2024 •
edited
Loading

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-chip X
test-fw-nrfconnect-nrf-iot_serial_lte_modem X
test-fw-nrfconnect-nrf-iot_zephyr_lwm2m X
test-fw-nrfconnect-zigbee X
test-sdk-find-my X
test-sdk-sidewalk X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@edmont edmont requested a review from Damian-Nordic April 2, 2024 08:09
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@edmont edmont requested a review from carlescufi as a code owner April 2, 2024 10:34
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Apr 2, 2024
@edmont
Copy link
Contributor Author

edmont commented Apr 2, 2024

Updated known issues.

@edmont edmont requested a review from wiba-nordic April 2, 2024 10:35
@edmont edmont requested a review from greg-fer April 3, 2024 06:57
greg-fer
greg-fer requested changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@greg-fer greg-fer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment.

edmont added 3 commits April 3, 2024 19:38
@edmont
dfu_target: disallow DFU_TARGET_STREAM_SAVE_PROGRESS
0763a4d 
Multi-image parser doesn't allow to resume the copy of an image.
Thus, disable saving progress for now.

Signed-off-by: Eduardo Montoya <eduardo.montoya@nordicsemi.no>
@edmont
zigbee: fota: release resources after a failed write
10e9899 
Make sure to release dfu_target resources after a failed chunk write
to be able to resume the image copy without a device reboot.

Signed-off-by: Eduardo Montoya <eduardo.montoya@nordicsemi.no>
@edmont
doc: zigbee: update known issues about FOTA update
8fb6f51 
Update known issues and changelog about NCSIDB-1213.

Signed-off-by: Eduardo Montoya <eduardo.montoya@nordicsemi.no>
@rlubos rlubos merged commit fcaa5af into nrfconnect:main Apr 4, 2024
19 checks passed
@edmont edmont deleted the pr/dfu-resume branch April 4, 2024 09:34
ktaborowski added a commit to ktaborowski/sdk-sidewalk that referenced this pull request Jun 17, 2024
@ktaborowski
samples: add single image dfu with Sidewalk fuota
88b3d80 
[KRKNWK-18739]
* modify file transfer module - support mcuboot
* write image to flash on file transfer event
* add reboot event
* move scratch buffer to utils
* group mcuboot log configs in prj.conf
* sort out heders, fix formating etc

Signed-off-by: Krzysztof Taborowski <krzysztof.taborowski@nordicsemi.no>

samples: fix flie transfer testing

tbd

Signed-off-by: Krzysztof Taborowski <krzysztof.taborowski@nordicsemi.no>

samples: disable strem flash progress

See nrfconnect/sdk-nrf#14684

Signed-off-by: Krzysztof Taborowski <krzysztof.taborowski@nordicsemi.no>
ktaborowski added a commit to ktaborowski/sdk-sidewalk that referenced this pull request Jun 18, 2024
@ktaborowski
samples: add single image dfu with Sidewalk fuota
e6e6ea3 
[KRKNWK-18739]
* modify file transfer module - support mcuboot
* write image to flash on file transfer event
* add reboot event
* move scratch buffer to utils
* group mcuboot log configs in prj.conf
* sort out heders, fix formating etc

Signed-off-by: Krzysztof Taborowski <krzysztof.taborowski@nordicsemi.no>

samples: fix flie transfer testing

tbd

Signed-off-by: Krzysztof Taborowski <krzysztof.taborowski@nordicsemi.no>

samples: disable strem flash progress

See nrfconnect/sdk-nrf#14684

Signed-off-by: Krzysztof Taborowski <krzysztof.taborowski@nordicsemi.no>

samples: fix build error

tbd

Signed-off-by: Krzysztof Taborowski <krzysztof.taborowski@nordicsemi.no>
ktaborowski added a commit to ktaborowski/sdk-sidewalk that referenced this pull request Jun 24, 2024
@ktaborowski
samples: add single image dfu with Sidewalk fuota
26038c4 
[KRKNWK-18739]
* modify file transfer module - support mcuboot
* write image to flash on file transfer event
* add reboot event
* move scratch buffer to utils
* group mcuboot log configs in prj.conf
* sort out heders, fix formating etc

Signed-off-by: Krzysztof Taborowski <krzysztof.taborowski@nordicsemi.no>

samples: fix flie transfer testing

tbd

Signed-off-by: Krzysztof Taborowski <krzysztof.taborowski@nordicsemi.no>

samples: disable strem flash progress

See nrfconnect/sdk-nrf#14684

Signed-off-by: Krzysztof Taborowski <krzysztof.taborowski@nordicsemi.no>

samples: fix build error

tbd

Signed-off-by: Krzysztof Taborowski <krzysztof.taborowski@nordicsemi.no>
ktaborowski added a commit to nrfconnect/sdk-sidewalk that referenced this pull request Jun 25, 2024
@ktaborowski
samples: add single image dfu with Sidewalk fuota
e2191c2 
[KRKNWK-18739]
* modify file transfer module - support mcuboot
* write image to flash on file transfer event
* add reboot event
* move scratch buffer to utils
* group mcuboot log configs in prj.conf
* sort out heders, fix formating etc

Signed-off-by: Krzysztof Taborowski <krzysztof.taborowski@nordicsemi.no>

samples: fix flie transfer testing

tbd

Signed-off-by: Krzysztof Taborowski <krzysztof.taborowski@nordicsemi.no>

samples: disable strem flash progress

See nrfconnect/sdk-nrf#14684

Signed-off-by: Krzysztof Taborowski <krzysztof.taborowski@nordicsemi.no>

samples: fix build error

tbd

Signed-off-by: Krzysztof Taborowski <krzysztof.taborowski@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-fer greg-fer greg-fer approved these changes

@AdamZelikNS AdamZelikNS AdamZelikNS approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@milewr milewr milewr approved these changes

@hakonfam hakonfam Awaiting requested review from hakonfam

@sigvartmh sigvartmh Awaiting requested review from sigvartmh

@carlescufi carlescufi Awaiting requested review from carlescufi

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

Assignees
No one assigned
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@edmont @NordicBuilder @greg-fer @AdamZelikNS @Damian-Nordic @milewr @rlubos