subsys: fs: bm_zms: remove bm_zms_register and fix event clear bug #504
+91
−149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc-required
|
You can find the documentation preview for this PR here. |
MirkoCovizzi
changed the title
peknis
requested changes
Nov 25, 2025
|
|
||
| * Removed: | ||
|
|
||
| * The :kconfig:option:`CONFIG_BM_ZMS_MAX_USERS` Kconfig option. |
There was a problem hiding this comment.
Suggested change
| * The :kconfig:option:`CONFIG_BM_ZMS_MAX_USERS` Kconfig option. | |
| * The ``CONFIG_BM_ZMS_MAX_USERS`` Kconfig option. |
Contributor
Author
There was a problem hiding this comment.
This refers to a commit belonging to a different PR #485
There was a problem hiding this comment.
This refers to a commit belonging to a different PR #485
But the Kconfig option is going to be removed anyway, right. So we can have it without :kconfig:option: as it will not link to the Kconfig reference anymore, if it ever did.
Contributor
Author
There was a problem hiding this comment.
I addressed it in the original PR :) this is just building on top of those commits
Comment on lines
146
to
147
| * The :c:member:`bm_zms_init_flags.cb_registred` member as it was not used anymore. | ||
| * The :c:func:`bm_zms_register` function. |
There was a problem hiding this comment.
Suggested change
| * The :c:member:`bm_zms_init_flags.cb_registred` member as it was not used anymore. | |
| * The :c:func:`bm_zms_register` function. | |
| * The ``bm_zms_init_flags.cb_registred`` member as it was not used anymore. | |
| * The ``bm_zms_register`` function. |
* Removes typedefs * Renames `BM_ZMS_EVT_INIT` to `BM_ZMS_EVT_MOUNT` * Renames `bm_zms_evt.evt_id` to `bm_zms_evt.evt_type` * Removes hungarian notation * Improves doxygen * Other misc cleanup Signed-off-by: Mirko Covizzi <mirko.covizzi@nordicsemi.no>
* Removes `bm_zms_register` and moves the event handler configuration into `bm_zms_fs_config`. * Renames the `bm_zms_cb_t` type to `bm_zms_evt_handler_t`. Signed-off-by: Mirko Covizzi <mirko.covizzi@nordicsemi.no>
MirkoCovizzi
force-pushed
the
zms-clean
branch
from
5cfe74d to
fbbfd27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #501
TODOs: