DFU: support for App -> Loader ADV name setup over settings retention backend #495

nvlsianpu · 2025-11-19T15:43:49Z

move retainedmem node to exclusive SRAM space compatible = "zephyr,memory-region" :: retainedmem :: compatible = "zephyr,retained-ram" :: settings_partition0: settings_partition@0
- boards/nordic/bm_nrf54l15dk: fix cpuapp SRAM/retained mem overlap #506

github-actions · 2025-11-19T15:45:01Z

You can find the documentation preview for this PR here.

applications/firmware_loader/ble_mcumgr/src/main.c

sonarqubecloud · 2025-11-20T09:44:55Z

Quality Gate failed

Failed conditions
3 Security Hotspots

See analysis details on SonarQube Cloud

doc/nrf-bm/app_dev/dfu/dfu_name.rst

include/bm/settings/bluetooth_name.h

doc/nrf-bm/app_dev/dfu/dfu_name.rst

peknis · 2025-11-25T11:14:42Z

subsys/mgmt/mcumgr/grp/settings_mgmt/CMakeLists.txt

@@ -0,0 +1,18 @@
+#
+# Copyright (c) 2023 Nordic Semiconductor ASA


Suggested change

# Copyright (c) 2023 Nordic Semiconductor ASA

# Copyright (c) 2025 Nordic Semiconductor ASA

this was copied from zephtr-rtos. What time stamp should be there.

this was copied from zephtr-rtos. What time stamp should be there.

Up to you.

doc/nrf-bm/app_dev/dfu/dfu_name.rst

peknis · 2025-11-25T11:19:07Z

doc/nrf-bm/app_dev/dfu/dfu_name.rst

+1.
+To enable this feature for a sysbuild project, use the :kconfig:option:`SB_CONFIG_BM_APP_CAN_SETUP_FIRMWARE_LOADER_NAME` Kconfig option.
+Otherwise, enable the following Kconfig options in both the application and the firmware loader configuration:


Suggested change

1.

To enable this feature for a sysbuild project, use the :kconfig:option:`SB_CONFIG_BM_APP_CAN_SETUP_FIRMWARE_LOADER_NAME` Kconfig option.

Otherwise, enable the following Kconfig options in both the application and the firmware loader configuration:

To enable this feature for a sysbuild project, use the :kconfig:option:`SB_CONFIG_BM_APP_CAN_SETUP_FIRMWARE_LOADER_NAME` Kconfig option.

Also enable the following Kconfig options in both the application and the firmware loader configuration:

Otherwise - Alternatively?
I mean that actually SB_CONFIG_BM_APP_CAN_SETUP_FIRMWARE_LOADER_NAME enables all of these CONFIG_xyx.

Alternatively sounds better.

peknis · 2025-11-25T11:19:44Z

doc/nrf-bm/app_dev/dfu/dfu_name.rst

+* :kconfig:option:`CONFIG_SETTINGS_RETENTION`- Enables retention backend implementation of settings subsystem.
+* :kconfig:option:`CONFIG_NCS_BM_SETTINGS_BLUETOOTH_NAME`- Enables setting handlers required for Bluetooth name sharing support.
+
+#.


Suggested change

#.

doc/nrf-bm/app_dev/dfu/dfu_name.rst

peknis · 2025-11-25T11:22:03Z

doc/nrf-bm/app_dev/dfu/dfu_name.rst

+Usage example
+*************
+


Suggested change

Usage example

*************

peknis

Approved with a couple of nits.

peknis · 2025-11-26T08:59:36Z

doc/nrf-bm/app_dev/dfu/dfu_name.rst

+********************
+
+To enable this feature for a sysbuild project, use the :kconfig:option:`SB_CONFIG_BM_APP_CAN_SETUP_FIRMWARE_LOADER_NAME` Kconfig option.
+Otherwise, enable the following Kconfig options in both the application and the firmware loader configuration:


Suggested change

Otherwise, enable the following Kconfig options in both the application and the firmware loader configuration:

Alternatively, enable the following Kconfig options in both the application and the firmware loader configuration:

peknis · 2025-11-26T08:59:49Z

doc/nrf-bm/app_dev/dfu/dfu_name.rst

+* :kconfig:option:`CONFIG_SETTINGS_RETENTION`- Enables retention backend implementation of settings subsystem.
+* :kconfig:option:`CONFIG_NCS_BM_SETTINGS_BLUETOOTH_NAME`- Enables setting handlers required for Bluetooth name sharing support.
+
+Additionally, the application must enable the MCUmgr settings group using the following Kconfig options:


Suggested change

Additionally, the application must enable the MCUmgr settings group using the following Kconfig options:

Additionally, the application must enable the MCUmgr settings group using the following Kconfig options:

peknis · 2025-11-26T09:00:27Z

subsys/mgmt/mcumgr/grp/settings_mgmt/CMakeLists.txt

@@ -0,0 +1,18 @@
+#
+# Copyright (c) 2023 Nordic Semiconductor ASA


this was copied from zephtr-rtos. What time stamp should be there.

Up to you.

Adds a settings subsystem file to add a bluetooth name setting Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no> Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>

Allows usage of this from BM applications Files taken from zephyr commit: 0fe59bf1e4b96122c3467295b09a034e399c5ee6 Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no> Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>

Adds code to get bluetooth name from retention backend of the settings subsystem. Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no> Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>

Adds code to set bluetooth name to retention settings Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no> Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>

Added enabler for coherent setup of the BLE name from the application to the firmware loader using the settings subsystem with retention memory backend. Applied usage of this to configuration of the mcuboot_recovery_entry sample and the BLE firmware loader. Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>

Documented feature of setup the firmware loader BLE name by the remote MCUmgr client using the application's MCUmgr and the settings. Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no> Signed-off-by: Pekka Niskanen <pekka.niskanen@nordicsemi.no>

Assigns this to eris Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>

nvlsianpu requested review from a team as code owners November 19, 2025 15:43

nvlsianpu changed the title ~~Retentionloader~~ DFU: support for App -> Loader ADV name setup over settings retention backend Nov 19, 2025

nvlsianpu added this to the v1.0.0 milestone Nov 19, 2025

kszromek-nordic reviewed Nov 20, 2025

View reviewed changes

applications/firmware_loader/ble_mcumgr/src/main.c Outdated Show resolved Hide resolved

nvlsianpu force-pushed the retentionloader branch from 89e616c to bd2732d Compare November 20, 2025 12:10

nvlsianpu changed the title ~~DFU: support for App -> Loader ADV name setup over settings retention backend~~ [WIP] DFU: support for App -> Loader ADV name setup over settings retention backend Nov 20, 2025

nvlsianpu force-pushed the retentionloader branch 4 times, most recently from 7dde0be to aaa5c05 Compare November 21, 2025 17:19

nvlsianpu requested a review from a team as a code owner November 21, 2025 18:32

github-actions bot added the doc-required PR must not be merged without tech writer approval. label Nov 21, 2025

nvlsianpu changed the title ~~[WIP] DFU: support for App -> Loader ADV name setup over settings retention backend~~ DFU: support for App -> Loader ADV name setup over settings retention backend Nov 21, 2025

nvlsianpu commented Nov 21, 2025

View reviewed changes

doc/nrf-bm/app_dev/dfu/dfu_name.rst Outdated Show resolved Hide resolved

peknis requested changes Nov 24, 2025

View reviewed changes

nvlsianpu force-pushed the retentionloader branch 5 times, most recently from c2e85d1 to fca3dfa Compare November 25, 2025 10:38

nvlsianpu requested a review from peknis November 25, 2025 10:39

nvlsianpu force-pushed the retentionloader branch from fca3dfa to cfc5daa Compare November 25, 2025 10:47

peknis requested changes Nov 25, 2025

View reviewed changes

nvlsianpu force-pushed the retentionloader branch 2 times, most recently from 4308f64 to 699da59 Compare November 26, 2025 08:38

nvlsianpu requested review from michalek-no and peknis November 26, 2025 08:46

peknis approved these changes Nov 26, 2025

View reviewed changes

michalek-no approved these changes Nov 26, 2025

View reviewed changes

nordicjm and others added 7 commits November 27, 2025 10:46

settings: Add bluetooth name subsystem

b8d9ad8

Adds a settings subsystem file to add a bluetooth name setting Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no> Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>

applications/firmware_loader/ble_mcumgr: integrated BLE ADV_NAME setup

1d19e83

Adds code to get bluetooth name from retention backend of the settings subsystem. Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no> Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>

samples: boot: mcuboot_recovery_entry: Add settings test code

7da385e

Adds code to set bluetooth name to retention settings Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no> Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>

codeowners: Add entry for settings & adv name setup

336dcba

Assigns this to eris Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>

nvlsianpu force-pushed the retentionloader branch from 699da59 to 336dcba Compare November 27, 2025 09:49

		@@ -0,0 +1,18 @@
		#
		# Copyright (c) 2023 Nordic Semiconductor ASA

	# Copyright (c) 2023 Nordic Semiconductor ASA
	# Copyright (c) 2025 Nordic Semiconductor ASA

	Otherwise, enable the following Kconfig options in both the application and the firmware loader configuration:
	Alternatively, enable the following Kconfig options in both the application and the firmware loader configuration:

	Additionally, the application must enable the MCUmgr settings group using the following Kconfig options:
	Additionally, the application must enable the MCUmgr settings group using the following Kconfig options:

DFU: support for App -> Loader ADV name setup over settings retention backend #495

Are you sure you want to change the base?

DFU: support for App -> Loader ADV name setup over settings retention backend #495

Conversation

nvlsianpu commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 19, 2025

Uh oh!

Uh oh!

sonarqubecloud bot commented Nov 20, 2025

Quality Gate failed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

peknis left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nvlsianpu commented Nov 19, 2025 •

edited

Loading