-
Notifications
You must be signed in to change notification settings - Fork 27
sysbuild: Add bootconf image #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Adds a semi-zephyr project which will lock the bootconf area on supported devices. Generates and flashes a seprate hex file which is also added into the production hex file. Some issues with CMake have also been tidied up to improve readability Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no> Signed-off-by: Mateusz Michalek <mateusz.michalek@nordicsemi.no>
|
You can find the documentation preview for this PR here. |
anhmolt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could use some documentation, and changelog(?).
Maybe mention here that the boot partition will be protected when CONFIG_BM_BOOT_BOOTCONF_LOCK_WRITES is set, and that recover or erase needs to be used to be able to flash the mcuboot+softdevice image again.
In any case, west flash will fail without --recover or --erase options after having programmed the bootconf "image". As intended. Could be good to explain why, and what to do, when seeing
-- west flash: using runner nrfutil
Using board 0123456789
-- runners.nrfutil: Flashing file: /ncs/nrf-bm/samples/bluetooth/ble_hids_keyboard/build/mcuboot/zephyr/zephyr_signed_softdevice_flash_metadata.hex
-- runners.nrfutil: Connecting to probe
-- runners.nrfutil: Programming image
Error: One or more batch tasks failed:
* 0123456789: Device error: Address 0x00000000 is in a protected RRAMC region (Generic)
FATAL ERROR: command exited with status 1: nrfutil --json device x-execute-batch --batch-path /ncs/nrf-bm/samples/bluetooth/ble_hids_keyboard/build/mcuboot/zephyr/generated_nrfutil_batch.json --serial-number 0123456789
| # Create the runners_yaml_props_target that flash system expects | ||
| add_custom_target(runners_yaml_props_target) | ||
|
|
||
| # Set hex_file property to point to zephyr.hex in this directory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this comment accurate?
| ) | ||
|
|
||
| # Override the runners.yaml path to use CMAKE_CURRENT_BINARY_DIR/zephyr instead of | ||
| # PROJECT_BINARY_DIR, this ensures runners.yaml is generated at <build>/softdevice/zephyr where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs updating. softdevice is not correct here.
|
|
||
| set(BYPRODUCT_HEX_NAME | ||
| "${CMAKE_BINARY_DIR}/bootconf.hex" | ||
| CACHE FILEPATH "MCUboot with signed softdevice and flash metadata hex file" FORCE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs update(?)
anhmolt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The incorrect comments can be fixed later. Let's get this merged.
Adds a semi-zephyr project which will lock the bootconf area on supported devices. Generates and flashes a seprate hex file which is also added into the production hex file. Some issues with CMake have also been tidied up to improve readability