Add database discovery library #431
Draft
+1,447
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
|
You can find the documentation preview for this PR here. |
Contributor
eivindj-nordic
left a comment
eivindj-nordic
left a comment
There was a problem hiding this comment.
Good start, please see issues in checkpatch and compliance actions.
sondrep
force-pushed
the
db_discovery
branch
8 times, most recently
from
b389cf3 to
3149d9a
Compare
asilz
force-pushed
the
db_discovery
branch
9 times, most recently
from
c3237e2 to
db79daf
Compare
github-actions
bot
removed
the
changelog-entry-required
asilz
force-pushed
the
db_discovery
branch
4 times, most recently
from
72acbdb to
0bbb35a
Compare
asilz
force-pushed
the
db_discovery
branch
6 times, most recently
from
dd6929e to
8b8ee20
Compare
|
|
asilz
force-pushed
the
db_discovery
branch
2 times, most recently
from
52bd1a7 to
060af68
Compare
eivindj-nordic
force-pushed
the
db_discovery
branch
from
060af68 to
1db4717
Compare
Signed-off-by: Sondre Pettersen <sondre.pettersen@nordicsemi.no> Co-authored-by: Asil Zogby <asilz@stud.ntnu.no>
- Remove Hungarian notation - Standardise comments - Add kconfigs - Fix error handling - Fix non const pointer in ble_db_discovery_config Signed-off-by: Sondre Pettersen <sondre.pettersen@nordicsemi.no> Co-authored-by: Asil Zogby <asilz@stud.ntnu.no>
Signed-off-by: Asil Zogby <asilz@stud.ntnu.no>
Signed-off-by: Asil Zogby <asilz@stud.ntnu.no>
- Move ble_gatt_db.h out of peer_manager - Remove duplicate structs from ble_db_discovery.h Signed-off-by: Sondre Pettersen <sondre.pettersen@nordicsemi.no>
Signed-off-by: Asil Zogby <asilz@stud.ntnu.no>
To be squashed. Signed-off-by: Eivind Jølsgard <eivind.jolsgard@nordicsemi.no>
eivindj-nordic
force-pushed
the
db_discovery
branch
from
1db4717 to
fe862ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.