Make the DECT-2020 NR+ libmodem.a available as a feature#16
Merged
diondokter merged 2 commits intonrf-rs:developfrom Jan 25, 2026
Merged
Make the DECT-2020 NR+ libmodem.a available as a feature#16diondokter merged 2 commits intonrf-rs:developfrom
diondokter merged 2 commits intonrf-rs:developfrom
Conversation
This was referenced Nov 11, 2025
Contributor
Author
|
diondokter/nrf-modem#52 now has an example program for this. |
Contributor
Author
|
An easier way to review this is now diondokter/nrf-modem#53. |
diondokter
approved these changes
Dec 19, 2025
Contributor
diondokter
left a comment
diondokter
left a comment
There was a problem hiding this comment.
Aside from not having tested it, it looks good.
I'll test and merge once I get access to the DECT modem firmware
Contributor
|
I've been able to get it working! So it seems we're good to go. When you fix the CI thingy I'll merge and cut a new release |
This is backed by observing structs such as nrf_modem_dect_phy_event: With packed enums, the fields in its nrf_modem_dect_phy_init_event make perfect sense (plausible voltage and temperatures, and no error); with long enums, it's all garbage data.
Contributor
Author
|
Thanks, and sorry I let this sit for 2 weeks. Formatting is fixed, having a new release with this would be great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a do-over of #15 after moving towards a testable application with nrf-modem.
Unlike the original approach it switches (rather than adding) the library; consequently, this needs to be feature-gated to keep the library usable. (The original idea with #15 was to just always link both, let the user decide what they reference and the linker what to gc, but actually the different libmodem.a have different texts for identical symbols).
How much this is additive (as features should be) I can not tell because I don't see into the proprietary libraries, but I guess that using DECT will break the other cases. But we're in low-level embedded crates, and feature additivity is generally not valued so much when there's already a hard decision for which chip is to be selected.
The issue remains that for this to be practically releasable, a firmware would need to be available.
An extra commit switches on short enums. It remains to be tested whether the radio libmodem is built this way as well.