Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing repository configuration regarding pull request merging #18

Closed
hannobraun opened this issue Sep 13, 2018 · 4 comments
Closed

Comments

@hannobraun
Copy link
Contributor

When merging pull requests, the option "Create a merge commit" is currently disabled in this repository. I actually prefer that option, as it documents in the commit history which commits belong to larger pieces of work.

"Squash and merge" is currently enabled. I suggest disabling it, as that makes it easy to accidentally lose valuable history, especially since it's currently the default option. Whenever squashing commits is desirable, it's easy enough to do manually.

I'd also prefer to disable "Rebase and merge", due to my preference for merge commits. I don't feel strongly about this point.

cc @nrf-rs/team, especially @wez

@jamesmunns
Copy link
Member

I generally prefer merge commits as well. No opinion from me regarding squash and merge.

@wez
Copy link
Member

wez commented Sep 13, 2018

I agree that squash should go. I personally prefer rebasing to keep history more linear (my day job is wrangling massive source control systems) but am fine with merging if that’s your collective preference.

@hannobraun
Copy link
Contributor Author

@wez

I agree that squash should go. I personally prefer rebasing to keep history more linear (my day job is wrangling massive source control systems) but am fine with merging if that’s your collective preference.

I don't feel too strongly, and I realize that linear history has its benefits. I think the main problem right now is that "Merge" is disabled, and "Squash" is at the top of the list. I'm perfectly fine with leaving "Rebase" enabled, and could even live with "Rebase" being the only option :)

@wez
Copy link
Member

wez commented Sep 13, 2018

I've turned off squash, which effectively makes rebase the "default". I've left merge out for now, but please don't hesitate to enable it if you have a situation where you want to merge.

@wez wez closed this as completed Sep 13, 2018
qwandor added a commit that referenced this issue May 24, 2024
* Test monotonic feature in CI.

* needs testing

* remove excessive unsafe

* Fix build.

* correct docs

---------

Co-authored-by: Andrew Walbran <qwandor@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants