Make core library no_std#25
Conversation
This both avoids the needless allocation, pushing it to the client if they need it, and enables `no_std`.
This feature only exists on packages, not targets.
|
Note that I've removed the version bump and started pushing miscelanneous commits, let me know if you want me to break them out. |
|
|
||
| [[bin]] | ||
| name = "xmas_elf" | ||
| publish = "false" |
There was a problem hiding this comment.
I think this is required otherwise we publish the bin (which is only meant for testing) to crates.io instead of the lib
There was a problem hiding this comment.
Cargo seems to claim it's unused. What does it even mean to publish a bin? The name xmas-elf becomes usable as a cargo install as well?
There was a problem hiding this comment.
(Also, it's only documented as a field on package sections, not bins)
There was a problem hiding this comment.
So, the first time I published this to crates.io, it used src/bin/main.rs as the crate (iirc) and it was useless. So I added this line and then publish published the lib (see this commit - 5e2cc78). This may well be horrible cargo culting (no pun intended), I just did what someone on irc told me rather than look into it properly.
There was a problem hiding this comment.
Not sure about publishing, but I've been using this branch as a git dep and it's been working without issue.
|
Thank you! |
|
Thank you :) |
2 participants
No description provided.