-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix photonuclear cross section biasing when using cross section enhancement #958
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ftessier this ended up being quite an undertaking!
Fixed the photonuclear I have checked that all applications and @nrc-cnrc/egsnrc please review as soon as possible so that we can include this fix in release 2023. |
Note that there are other instances of photon interaction ausgab calls, without a corresponding photonuclear call. But the ones I reviewed seem fine, since they have to do with what happens with the photon afterwards, whereas in the photonuclear interaction the photon is simply discarded. The following
@mainegra you might want to double-check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the changes here look correct. I'm still looking at egs_cbct and egs_fac but so far I don't think they need any changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Add ausgab calls before and after a photonuclear interaction, in order to handle cross section enhancement (xcse) correctly. Without these calls, there is no compensation for the enhanced cross section, hence the photonuclear cross section is effectively increased by the xcse factor. Also add the photonuclear event trapping in Fano calculations, for consistency. However, the Fano calculation fails when photonuclear attenuation is turned on anyway, because the photon is discarded without depositing its energy. Also update a couple loops that print out the ausgab flags (IAUSFL) values, to include the photonuclear attenuation option value.
70a7789
to
5599601
Compare
Squashed the commits. |
Add ausgab calls before and after a photonuclear interactions, in order to handle cross section enhancement (xcse) correctly. Without these calls, there is no compensation for the enhanced cross section, hence the photonuclear cross section is effectively increased.
Also, update a couple loops that print out the ausgab flags (IAUSFL) values, to include the photonuclear attenuation input value, and fix a couple typos.