Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added -mcmodel=medium as a default compiler flag #725

Merged
merged 1 commit into from
Jun 30, 2022
Merged

added -mcmodel=medium as a default compiler flag #725

merged 1 commit into from
Jun 30, 2022

Conversation

crcrewso
Copy link
Contributor

added -mcmodel=medium as a default compiler flag to default optimization flag lists
This targets issue #723 along with other similar issues

@crcrewso crcrewso requested a review from a team as a code owner May 21, 2021 16:53
@ftessier ftessier self-assigned this May 21, 2021
@ftessier ftessier added this to the Release 2022 milestone May 21, 2021
@ftessier
Copy link
Member

ftessier commented May 21, 2021 •
edited
Loading

Great! Note to self: update the configure gui accordingly.

@crcrewso
Copy link
Contributor Author

crcrewso commented May 21, 2021 •
edited by ftessier
Loading

Great! Note to self: update the configure gui accordingly.

Could you add the updated configure (maybe as an alternate branch)? I'd like to get the LLVM (and update PGI/ICC) compilers tested and configured and it just makes sense not to duplicate the efforts.

After the success with ARM and current indications that we're going to start seeing more ARM based clusters we'll need to support those too.

@ftessier
Copy link
Member

Could you add the updated configure (maybe as an alternate branch)? I'd like to get the LLVM (and update PGI/ICC) compilers tested and configured and it just makes sense not to duplicate the efforts.

I don't understand what you mean: you want me to create a new branch off develop with this PR's changes, for testing? But you can do that locally at your end, so I think I am missing the point...

@crcrewso
Copy link
Contributor Author

crcrewso commented May 21, 2021 •
edited
Loading

Could you add the updated configure (maybe as an alternate branch)? I'd like to get the LLVM (and update PGI/ICC) compilers tested and configured and it just makes sense not to duplicate the efforts.

I don't understand what you mean: you want me to create a new branch off develop with this PR's changes, for testing? But you can do that locally at your end, so I think I am missing the point...

Sorry, I meant for you to create a new branch with Your configure, unless it's a different filename and can live in develop in parallel.

@ftessier
Copy link
Member

Rebased on develop and added the -mcmodel=medium option to the the default flags in the egs_configure gui as well.

@ftessier ftessier merged commit 930014e into nrc-cnrc:develop Jun 30, 2022
@crcrewso crcrewso deleted the mcmodel branch June 30, 2022 20:21
@ftessier ftessier mentioned this pull request Jul 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ftessier ftessier ftessier approved these changes

@mainegra mainegra mainegra approved these changes

@rtownson rtownson rtownson approved these changes

Assignees

@ftessier ftessier

Labels
compilation improvement
Projects
None yet
Milestone
Release 2023
Development

Successfully merging this pull request may close these issues.
4 participants
@crcrewso @ftessier @mainegra @rtownson