Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix g bug: SEGFAULT when using spectrum #714

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Fix g bug: SEGFAULT when using spectrum #714

merged 1 commit into from
Jun 27, 2022

Conversation

mainegra
Copy link
Contributor

@mainegra mainegra commented May 7, 2021

g app crashes when used for a spectrum due to a superfluous command left
in entry point source_check_emin copied from entry point source_get_emax
during implementation of the former.

Thanks to @dworogers for reporting this bug.

@mainegra mainegra requested a review from a team as a code owner May 7, 2021 21:23
@mainegra mainegra requested review from ftessier, rtownson and blakewalters and removed request for a team May 7, 2021 21:23
@mainegra mainegra self-assigned this May 7, 2021
@ftessier
Copy link
Member

ftessier commented May 7, 2021

Shall we consider a release 2021a to address this? Otherwise it won't be fixed on master for another year...

@mainegra
Copy link
Contributor Author

mainegra commented May 8, 2021 •
edited
Loading

Shall we consider a release 2021a to address this? Otherwise it won't be fixed on master for another year...

Considering how few users run g, updating develop might be enough. Not sure issuing a release 2021a just for g is granted!

@mainegra
Copy link
Contributor Author

mainegra commented Jun 26, 2021 •
edited
Loading

@rtownson and @blakewalters could you please take a look at this PR? It is a one liner and should be merged ASAP! Pretty please?

@ftessier ftessier added this to the Release 2022 milestone Jun 28, 2021
@ftessier ftessier changed the base branch from master to develop June 27, 2022 18:05
@mainegra @ftessier
Fix entry point bug in g application
acb5b8d 
Remove superfluous command in entry point source_check_emin copied from
entry point source_get_emax during implementation, which was setting the
value for emax.

Not really clear to me why this was happening but it turns out that
having emax as an argument in one entry point would force to also have
in the other entry point to avoid SEGFAULT errors. However, line has
been removed as it shouldn't have been there in the first place!
@ftessier ftessier merged commit 753cfe8 into develop Jun 27, 2022
@ftessier ftessier deleted the fix-g-bug branch June 27, 2022 18:21
@kouadriaek
Copy link

Bonjour

j utlise dosxyz pour simulation quand j arrive a un nombre de 2.4 milliards de particules le code fais un bug

j ai le message job failed

@rtownson
Copy link
Collaborator

Bonjour

j utlise dosxyz pour simulation quand j arrive a un nombre de 2.4 milliards de particules le code fais un bug

j ai le message job failed

@kouadriaek please post this as a new issue. Include as much description as you can, including if running less particles works.

@kouadriaek
Copy link

Capture1 Capture2

@kouadriaek
Copy link

after 2.3 milliads of particules il have this message pic jointed .

@nrc-cnrc nrc-cnrc deleted a comment from kouadriaek May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ftessier ftessier ftessier approved these changes

@rtownson rtownson rtownson approved these changes

@blakewalters blakewalters blakewalters approved these changes

Assignees

@mainegra mainegra

Labels
bug critical
Projects
None yet
Milestone
Release 2023
Development

Successfully merging this pull request may close these issues.
5 participants
@mainegra @ftessier @kouadriaek @rtownson @blakewalters