Fix glib and egs_rz windows compilation #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good last-minute catch @rtownson! 🏅 😰 |
ftessier
approved these changes
Jan 31, 2020
blakewalters
approved these changes
Jan 31, 2020
mainegra
approved these changes
Jan 31, 2020
Use makefile macros for the make and remove commands, because these are named differently on Windows.
ftessier
force-pushed
the
fix-geom-compile
branch
from
0cec540 to
c54d0b2
Compare
|
Sqashed into a single commit and adjusted commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compilation of egs_glib and egs_rz geometries on windows. This bug was introduced in PR #103 that added the geometries.