Revert "Avoid infinite loop in conestack geometry" #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9f94ea4. The original commit was intended to fix an infinite loop in the conetack geometry, but ended up introducing geometry errors found in long simulations of ionization chambers. Additionally, the original issue was fixed independently by a different commit.
ftessier
approved these changes
May 3, 2019
blakewalters
approved these changes
May 3, 2019
mainegra
approved these changes
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9f94ea4. The original commit was intended to fix an infinite loop in the conetack geometry, but ended up also introducing geometry errors in long simulations of ionization chambers.
Additionally, I was not able to reproduce the original infinite loop issue after reverting the change (though it does reappear when I switch to v2018). There have been no other changes in the conestack geometry since then, so I am unsure what else might have fixed the issue. Maybe it was a rare event and the same seeds no longer generate the same path, so I am running longer simulations to check.
This commit should get added to master and we should add a v2019a tag to update the release.