Fix #528: Windows PowerShell bug with .exe in app_name #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a Windows PowerShell bug where the .exe extension on applications was included in the app_name variable. This resulted in a runtime error where the input file failed to be found. Now we check to see if there is a .exe at the end of the app_name, and remove it.
rtownson
force-pushed
the
fix-powershell-exe-bug
branch
from
6ebbfb2 to
9074094
Compare
blakewalters
approved these changes
May 5, 2019
mainegra
approved these changes
Sep 17, 2019
ftessier
approved these changes
Nov 19, 2019
|
@rtownson there is a problem with this fix: using |
rtownson
added a commit
that referenced
this pull request
Nov 21, 2019
Fix a bug that caused any egs++ application to crash immediately when run. This happened due to a misused of find_last_of instead of rfind when searching for an extension on the application name.
ftessier
pushed a commit
that referenced
this pull request
Nov 21, 2019
Fix a bug that caused any egs++ application to crash immediately when run. This happened due to a misuse of string method find_last_of instead of method rfind to reverse-search for the ".exe" extension substring in the application name.
ftessier
pushed a commit
that referenced
this pull request
Nov 21, 2019
Fix a bug that caused any egs++ application to crash immediately when run. This happened due to a misuse of string method find_last_of instead of method rfind to reverse-search for the ".exe" extension substring in the application name.
ftessier
pushed a commit
that referenced
this pull request
Nov 21, 2019
Fix a bug that caused any egs++ application to crash immediately when run. This happened due to a misuse of string method find_last_of instead of method rfind to reverse-search for the ".exe" extension substring in the application name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a
Windows PowerShellandgit bashbug where the .exe extension on applications was included in the app_name variable. This resulted in a runtime error where the input file failed to be found. Now we check to see if there is a .exe at the end of the app_name, and remove it.