Fix radionuclide source emission bugs #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtownson
force-pushed
the
fix-radionuclide-emissions
branch
from
3290bc5 to
2663431
Compare
rtownson
force-pushed
the
fix-radionuclide-emissions
branch
from
2663431 to
1688c33
Compare
blakewalters
approved these changes
Mar 3, 2019
Set the statistical weight of a particle to zero when the energy is zero during source generation in EGS_RadionuclideSource. Otherwise, extra energy is deposited since the rest mass is added to the source particle energy in the shower() routine. Fix a bug where the branching ratio was not used for alpha records in EGS_RadionuclideSource. Add a check to make sure the branching ratios add up to 1 for the products of a given parent nuclide. If not, the missing branch is assumed to be fission. Add support for P and Q shells for the initial vacancies of relaxations from decays. Change the relaxation emissions to use the intensity of each shell, instead of the total intensity from the ENSDF file. This is necessary since the shell intensities do not always add up to the total intensity. Improve compatibility with NNDC (National Nuclear Data Center) ensdf files, by allowing for the normalization to be neglected. Also improve the robustness of checking comments for atomic relaxation data.
Account for the uncertainties on the decay intensities when the total decay intensity does not equal 100. Use the total intensity for internal conversion, even if the individual shell intensities don't add up to equal the total. Improve the handling of internal transitions from unknown levels, including fixing a bug where the total transition intensity was assigned to the gamma intensity. Add the option to model extra transitions when there is a mismatch between the intensities in and out of a level in the daughter. Fix a bug where internal pair intensity was read as P-shell internal conversion intensity. Remove a duplicated decay in the Th-234 ensdf file.
Sample of internal pair production during internal transitions in the radionuclide source model. This improves the accuracy of internal transition decay rates. However, currently the electron-positron pair following internal pair production is not produced when the event is sampled. This is left for future work.
ftessier
force-pushed
the
fix-radionuclide-emissions
branch
from
43f7cfb to
9bfb9be
Compare
ftessier
approved these changes
Mar 5, 2019
mainegra
approved these changes
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fairly major overhaul of the radionuclide source, fixing a number of bugs and improving overall modelling accuracy. Comparisons against experimental radionuclide calibrator (Vinten chamber) results show these improvements had a relatively small impact, but this was only for a subset of radionuclides in certain conditions.
Improve the normalization of decays, so that the uncertainties on the decay intensities are accounted for when the total decay intensity does not equal 100.
Change the internal conversion to use the total intensity, even if the individual shell intensities don't add up to equal the total.
Improve the handling of internal transitions from unknown levels, including fixing a bug where the total transition intensity was assigned to the gamma intensity.
Add an option of whether or not to model extra transitions when the intensity feeding and leaving a level in the daughter do not match.
Fix a bug where internal pair intensity was read as P-shell internal conversion intensity. Add sampling of internal pair production during internal transitions in the radionuclide source model. This improves the accuracy of internal transition decay rates. However, currently the electron positron pair following internal pair production is not produced when the event is sampled. This will be left for future work.
Fix a typo in the Th-234 ensdf file, where one decay was duplicated.
Fix a bug where particles were killed by setting their energy to zero, but not their weight, during source generation in EGS_RadionuclideSource. This resulted in extra dose being deposited since the rest mass is added to the source particle energy in shower(). This bug only existed since commit e562f24 and did not make it into the
masterbranch.Fix a bug where the branching ratio was not used for alpha records in EGS_RadionuclideSource. Add a check to make sure the branching ratios add up to 1 for the products of a given parent nuclide. If not, the missing branch is assumed to be fission.
Add support for P and Q shells for the initial vacancies of relaxations from decays.
Improved compatibility with ensdf files from NNDC by allowing the normalization record values to be omitted and assumed as 1.
Improved the robustness of checking comments in ensdf files for atomic relaxation data.