-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix synchdmlc dimension check and medium bugs #455
Conversation
Not quite sure why branch fix-call_vcusource_w_zsrcdum is also included with this, but there you have it. |
Sorry but on which file should I change these? I do not want to make a mistake and if you could tell the exact path, I would be glad. |
@deryayucel I recommend waiting until this is at least merged into the |
@rtownson I am studying on HDMLC and this error forced me to write wrong data to start run. So, if I could do it, it would be better. But do you think it is risky to do it because it is not tested yet? I am not an expert and your opinion matters to me. |
@rtownson I checked Files Changed tab but there are many files which are to be changed. All of them are necessary to fix this? Or each one changes something else and I need only one of them? |
@deryayucel I'm not sure these changes fix the error you reported on g+. I submitted that bug as issue #459. I recommend waiting a couple weeks for these fixes to get merged into develop. If you can't wait, make sure to use |
Hi @deryayucel and @rtownson: Most of these changes are for the GUI and documentation. If you just want to run with the corrected restriction on W_railbot and fixed FULL leaves, just apply the changes to the SYNCHDMLC_cm.mortran file. |
065d7d2
to
e0583cb
Compare
@blakewalters from what I understand @ojalaj has the designated cross sections for the #1 and #60 outboard leaves. Is it possible that he has different specs? We can address this in a separate issue perhaps. |
e0583cb
to
d4d9784
Compare
1. Change restriction on width of bottom of support rail (W_railbot) for quarter and half target leaves from W_railbot >= W_tip + W_groove to W_railbot <= W_tip + W_groove in accordance with TrueBeam specifications. Also change BEAMnrc and the gui accordingly. 2. Fix a bug in full leaves in which much of the leaf cross section was left filled with air instead of actual leaf medium.
Input lines for all cross section dimensions must still exist but these can be filled with blanks, zeroes or arbitrary real numbers for unused leaf types in the multi-leaf collimator model.
d4d9784
to
5cfe1bf
Compare
Fix #441 and #442: Fixes to SYNCHDMLC
quarter and half target leaves from W_railbot >= W_tip + W_groove to
W_railbot <= W_tip + W_groove in accordance with TrueBeam
specs. Accompanying changes to the BEAMnrc and the GUI.
was left filled with air instead of actual leaf medium.