Fix execute chown and chgrp for symlink

[npwalker]

Description

Used resource:

recursive_file_permissions { '/usr/lib/one/sunstone':
    file_mode => '0644',
    dir_mode  => '0755',
    owner     => 'root',
    group     => 'oneadmin',
}

exec:

find /usr/lib/one/sunstone "(" -type f '!' -perm 0644 ")" \
-o "(" -type d '!' -perm 0755 ")" \
-o "(" '!' -user root ")" \
-o "(" '!' -group oneadmin ")" | grep '.*'

result:

/usr/lib/one/sunstone/public/dist/main.js

this is symlink:

ls -la main.js
lrwxrwxrwx 1 oneadmin oneadmin 29 Apr  7 15:21 main.js -> /var/lib/one/sunstone/main.js

The next step is to run the chown command for the file /usr/lib/one/sunstone/public/dist/main.js, which modifies /var/lib/one/sunstone/main.js. But next time the puppet will find the given file again. (recursive loop).

The resource should change the symlink, not the file that she points to.

Fixes

Use the -h option for chown and chgrp. This option is supported by all operating systems for which support for this module is claimed.

--dereference
affect the referent of each symbolic link (this is the default),
rather than the symbolic link itself

-h, --no-dereference
affect each symbolic link instead of any referenced file
(useful only on systems that can change the ownership/group of a symlink)

[npwalker]

@tryfunc I recreated this as #6 was closed when I removed the master branch.

[reidmv]

Looks good to me conceptually. Maybe a little over-engineered? I'd suggest just hard-coding in "-h" to the two relevant places. There is no known variance for this flag on any platform, making setting and using $h unneeded.

[tryfunc]

This is logical, I agree. Updated the commit.

[reidmv]

LGTM! 👍