Support for multiple responsive iframes on one page. #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 25, 2013 15:41
… well as the height to the parent and then only resizing the iframe with the matching src attribute; Cleaned up the fallback code to both set and check the height hash on the frame. This is still blocked by cross-domain scripting restrictions, however it is not breaking the page in IE7
ghost
assigned
Contributor
|
Thanks a lot for the PR, Sarah. This sounds great. We will try to review and test as soon as possible. |
Author
|
I noticed one shortcoming with my method: when you navigate to other pages within the iframe it stops resizing because the location.href of the frame will no longer match an iframe src on the top page. But ideally it should continue to be responsive as long as the page navigated to also has responsiveIframe called on it. As is, it's not broken, it's just not responsive after leaving the first page. I'm working on a fix now. |
…href to iframe src. This will allow navigation to new pages within a responsive frame to continue to resize as long as new pages also call allow embedding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for multiple iframes on one page by passing the href as well as the height to the parent window in postMessage, and then only resizing the iframe with the matching src attribute. I have tested it with cross-domain frames in IE8+, Chrome, Safari, and Firefox.
It seems the existing fallback method was setting the hash in the frame window and then checking it in the parent window. It is now setting it in the frame and checking each iframe for its content window hash. Still doesn't work across domains, but I have added a catch so it won't error. This is still only applied to IE7 and other browsers where postMessage is not supported.
Lastly, I cleaned up the files to pass as much of jslint as possible.