refactor: use justify-content: space-between in AppFooter
#340
+11
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In npmx-dev#318, `justify-content: space-between` was removed unnecessary and a hack was introduced in its place. Flexbox layout already is directionality/writing-mode aware and `justify-content` has no bearing on the order of items, just their placement within the “main” axis. This switches back to what it was before which is simpler as it doesn’t add extra elements, presentational elements that are hidden with ARIA.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #318,
justify-content: space-betweenwas removed unnecessary and a hack was introduced in its place.Flexbox layout already is directionality/writing-mode aware and
justify-contenthas no bearing on the order of items, just their placement within the “main” axis (which is what gets flipped fordir=rtl; for a visual see: https://rtlstyling.com/posts/rtl-styling/#flexbox-layout-module).This switches back to what it was before which is simpler as it doesn’t add extra elements or presentational, spacer elements that are hidden with ARIA.
To test, set
dir=rtlon the<html>element and compare with the live site. Visually there should be no change.