Skip to content

Conversation

@userquin
Copy link
Contributor

@userquin userquin commented Jan 29, 2026

This PR includes:

  • replaces all margins and paddings: ml-, mr-, pl- and pr- with ms-, me-, ps- and pe- respectivelly
  • replaces all texts alignments: text-left and text-right with text-start and text-end respectivelly
  • replaces all abosulte positions: left- and right- with inset-is- and inset-ie respectivelly
  • replaces all borders and rounded borders: border-l, border-l-, border-r, border-r-, rounded-land rounded-r with border-is, border-is-, border-ie, border-ie-, rounded-is and rounded-ie respectivelly
  • adds rtl-flip to icons that have left or right direction: will require a deep review to check every icon
  • changes buttons styles for role switch at setting page: using RTL have wrong translate-x values => just added scoped style using html[dir="rtl"] to change the span inside the last span containing the check; replaced also justify-between with justify-start style adding a new span between the text and the check to allow swap positions on RTL
  • changed AppFooter component to add the same hack with justify-between for the links container (docs, source, social... links).
  • changes all icons found replacing previous styles to use i-<collection>: when using i-<collection>- (use : instead - for separator)

I still need to review a few entries:left-full and right-full and review all the icons that have left or right direction t add rtl-flip class.

You can check this PR on dev server adding dir="rtl" in the html element, we need to add ar and ar-EG locales.

Maybe this PR can be used as guide if you don't want that ammount of changes.

@vercel
Copy link

vercel bot commented Jan 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Jan 29, 2026 4:30pm
npmx.dev Error Error Jan 29, 2026 4:30pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
npmx-lunaria Ignored Ignored Jan 29, 2026 4:30pm

Request Review

@userquin
Copy link
Contributor Author

I'm going to send small PR for every page and component.

@danielroe
Copy link
Collaborator

I'm happy if you want to batch these prs up rather than per component.

@userquin
Copy link
Contributor Author

I'm happy if you want to batch these prs up rather than per component.

I want to check if there is conflict, will send pr per page/component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants