-
Notifications
You must be signed in to change notification settings - Fork 91
feat(ui): replace all left/right css styles for rtl support #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
userquin
wants to merge
1
commit into
npmx-dev:main
Choose a base branch
from
userquin:feat-add-rtl-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+155
−147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
Author
|
I'm going to send small PR for every page and component. |
This was referenced Jan 29, 2026
Collaborator
|
I'm happy if you want to batch these prs up rather than per component. |
This was referenced Jan 29, 2026
Contributor
Author
I want to check if there is conflict, will send pr per page/component |
This was referenced Jan 29, 2026
This was referenced Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
ml-,mr-,pl-andpr-withms-,me-,ps-andpe-respectivellytext-leftandtext-rightwithtext-startandtext-endrespectivellyleft-andright-withinset-is-andinset-ierespectivellyborder-l,border-l-,border-r,border-r-,rounded-landrounded-rwithborder-is,border-is-,border-ie,border-ie-,rounded-isandrounded-ierespectivellyrtl-flipto icons that have left or right direction: will require a deep review to check every iconhtml[dir="rtl"]to change the span inside the last span containing the check; replaced also justify-between with justify-start style adding a new span between the text and the check to allow swap positions on RTLi-<collection>:when usingi-<collection>-(use:instead-for separator)I still need to review a few entries:
left-fullandright-fulland review all the icons that have left or right direction t addrtl-flipclass.You can check this PR on dev server adding
dir="rtl"in the html element, we need to addarandar-EGlocales.Maybe this PR can be used as guide if you don't want that ammount of changes.