Skip to content

chore: remove unused version utils - #3096

Merged
gameroman merged 1 commit into
npmx-dev:mainfrom
gameroman:cleanup-version-utils
Jul 29, 2026
Merged

chore: remove unused version utils#3096
gameroman merged 1 commit into
npmx-dev:mainfrom
gameroman:cleanup-version-utils

Conversation

@gameroman

Copy link
Copy Markdown
Member

🔗 Linked issue

🧭 Context

📚 Description

@vercel

vercel Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Jul 29, 2026 12:38pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Jul 29, 2026 12:38pm
npmx-lunaria Ignored Ignored Jul 29, 2026 12:38pm

Request Review

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 956444a9-3d3e-4f7e-8347-f0a07468e716

📥 Commits

Reviewing files that changed from the base of the PR and between 9d65f44 and 01edd97.

📒 Files selected for processing (2)
  • app/utils/versions.ts
  • test/unit/app/utils/versions.spec.ts
💤 Files with no reviewable changes (1)
  • test/unit/app/utils/versions.spec.ts

📝 Walkthrough

Summary by CodeRabbit

  • Refactor

    • Streamlined internal version and tag handling by removing obsolete version-validation and tag-sorting utilities.
    • Existing version grouping, filtering, comparison, and tag display behaviour remains supported.
  • Tests

    • Updated automated coverage to reflect the simplified version-handling logic while retaining checks for active version utilities.

Walkthrough

Removed the isExactVersion and sortTags exports from the version utilities, along with the unused verkit import and their corresponding unit tests.

Changes

Version utility cleanup

Layer / File(s) Summary
Remove obsolete version helpers
app/utils/versions.ts, test/unit/app/utils/versions.spec.ts
The isExactVersion and sortTags helpers, their imports, and their dedicated tests were removed. Remaining version utility tests are unchanged.

Possibly related PRs

Suggested reviewers: sxzz

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is a generic template and does not convey the actual changes. Replace the template text with a brief summary of the files changed and the unused helpers removed.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the change: removing unused version utilities.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@graphieros graphieros left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌿

@gameroman
gameroman added this pull request to the merge queue Jul 29, 2026
Merged via the queue into npmx-dev:main with commit 9ecfb1c Jul 29, 2026
25 checks passed
@gameroman
gameroman deleted the cleanup-version-utils branch July 29, 2026 17:18
@github-actions github-actions Bot mentioned this pull request Jul 29, 2026
ayo-run pushed a commit to ayo-run/npmx.dev that referenced this pull request Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants