Skip to content

Conversation

@mikouaji
Copy link
Contributor

@mikouaji mikouaji commented Jan 29, 2026

Resolves: #265
Does not replace npmjs url without a path present

@vercel
Copy link

vercel bot commented Jan 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Jan 29, 2026 11:24pm
npmx.dev Ready Ready Preview, Comment Jan 29, 2026 11:24pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Preview Jan 29, 2026 11:24pm

Request Review

@danielroe
Copy link
Collaborator

if we want to stay within the app, we need to do more than replace the URLs - we also need to handle clicks on them to use client-side routing.

we could add a click handler to the readme container, and listen for clicks on npmjs urls, instead. then normalise them to our format. if our router doesn't recognise url format, then we send it to npmjs instead.

@mikouaji
Copy link
Contributor Author

if we want to stay within the app, we need to do more than replace the URLs - we also need to handle clicks on them to use client-side routing.

we could add a click handler to the readme container, and listen for clicks on npmjs urls, instead. then normalise them to our format. if our router doesn't recognise url format, then we send it to npmjs instead.

I agree, solving it that way will be way better, will look into updating it in the evening

Copy link
Collaborator

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thank you ❤️

@danielroe danielroe enabled auto-merge January 29, 2026 23:23
@danielroe danielroe added this pull request to the merge queue Jan 29, 2026
Merged via the queue into npmx-dev:main with commit 7c1bbe9 Jan 29, 2026
13 checks passed
@mikouaji mikouaji deleted the feat/convert-npmjs-readme-urls-to-npmx branch January 30, 2026 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace some npm links in package READMEs with npmx

2 participants