-
Notifications
You must be signed in to change notification settings - Fork 106
feat: convert npmjs urls in readme with npmx #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: convert npmjs urls in readme with npmx #281
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
if we want to stay within the app, we need to do more than replace the URLs - we also need to handle clicks on them to use client-side routing. we could add a click handler to the readme container, and listen for clicks on npmjs urls, instead. then normalise them to our format. if our router doesn't recognise url format, then we send it to npmjs instead. |
I agree, solving it that way will be way better, will look into updating it in the evening |
…clicks and handle redirects there
danielroe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! thank you ❤️
Resolves: #265
Does not replace npmjs url without a path present