Skip to content

feat: change i18n configuration #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
userquin wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feat: change i18n configuration #245

userquin wants to merge 15 commits into from
+5,152 −25

Conversation

@userquin
Copy link
Contributor

@userquin userquin commented Jan 28, 2026 •
edited
Loading

This PR includes:

  • moves i18n configuration to config folder
  • adds support for multiple json files (country variants)
  • allows configure rtl, numberFormats, dateTimeFormats and pluralRule
  • setups initial language from local storage (added to the settings, you may need to clear npmx-settings entry + page refresh) via client plugin => now language is restored on page refrresh
  • restores stored language from local storage: changed setting page to just bind the settings.language
  • added some composables and helpers functions: counting kilo/mega for example (intl compact style => check i18n composable, we may need to add some missing entries if required => time ago for example)
  • included isHydrated and wrapI18n hack at elk.zone
  • added script to prepare translation json files for lunaria

I have left the same languages used at elk.zone, keeping just the current used here.

@vercel
Copy link

vercel bot commented Jan 28, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Jan 28, 2026 11:25pm
npmx-lunaria Error Error Jan 28, 2026 11:25pm
npmx.dev Ready Ready Preview, Comment Jan 28, 2026 11:25pm

Request Review

@userquin
Merge branch 'main' into feat-change-i18n-configuration
045d73d 
# Conflicts:
#	package.json
#	pnpm-lock.yaml
@userquin userquin marked this pull request as draft January 28, 2026 17:42
@userquin
Copy link
Contributor Author

userquin commented Jan 28, 2026

I'm going to resolve conflicts and merge messages for lunaria 🤞

@userquin userquin marked this pull request as ready for review January 28, 2026 18:40
yanthomasdev
yanthomasdev approved these changes Jan 28, 2026
View reviewed changes
Copy link
Contributor

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Lunaria workaround makes sense to me. Just pointing out that since we are not tracking the real files the Action won't show up in PRs, but since it's just temporary till I add the feature inside Lunaria it won't be a problem.

I would maybe make so lunaria-json-files are lunaria/files or something so everything concerning Lunaria outside config is in the same folder, but definitely not blocking.

@userquin
Copy link
Contributor Author

userquin commented Jan 28, 2026 •
edited
Loading

I would maybe make so lunaria-json-files are lunaria/files or something so everything concerning Lunaria outside config is in the same folder, but definitely not blocking.

I added that folder to .gitignore then removed, we can generate json files inside the lunaria/files folder 👍

userquin
userquin commented Jan 28, 2026
View reviewed changes
userquin
userquin commented Jan 28, 2026
View reviewed changes
app/utils/i18n.ts Outdated
const { t, d, n, ...rest } = useOriginalI18n()
const i18n = useOriginalI18n()

const { t, d, n, ...rest } = i18n
Copy link
Contributor Author

@userquin userquin Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argg, undo this

@userquin
Copy link
Contributor Author

userquin commented Jan 28, 2026

I'm going to split this PR to include i18n configuration and handle hydration missmatch issues.

@skaldebane
Copy link

skaldebane commented Jan 29, 2026

storing the language in local storage works but it means there's always a flash of english UI before the js kicks in
using a cookie would solve this, as it would be rendered in the correct language on the server

this is what i usually use in sveltekit, could take a stab at it, tho i'm not super familiar with nuxt just yet :P

@skaldebane skaldebane mentioned this pull request Jan 29, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yanthomasdev yanthomasdev yanthomasdev approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@userquin @skaldebane @yanthomasdev