perf: use vue router to parse package page paths #158
+50
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
serhalp
approved these changes
Jan 27, 2026
app/pages/[...package].vue
Outdated
Comment on lines
20
to
25
| path: '/:org(@[^/]+/)?:name([^@/]+):version()?', | ||
| alias: [ | ||
| '/:org(@[^/]+/)?:name([^@/]+)/v/:version()?', | ||
| '/package/:org(@[^/]+/)?:name([^@/]+):version()?', | ||
| '/package/:org(@[^/]+/)?:name([^@/]+)/v/:version()?', | ||
| ], |
Collaborator
Author
There was a problem hiding this comment.
it's not quite working - I want to render the version conditionally, and only if there is one 😞 - optionality of version is killing me here....
I'll have to implement slightly differently I fear.
in the next vue-router version we'll get proper matching
There was a problem hiding this comment.
As mentioned on Discord, here is a version that handles a few extra things:
- https://paths.esm.dev/?p=AAMeJbiAQB8CHASWMTCsgXOQmAKAElD8YA-mE-nzADwNCB6gArgN6A5A4K4AGUh2bQsDnsxq5FoNgAnbzgAsAfCIGqn8pAHwtdNAwAQUCRiik5DHUqQo5WbQlyN9Sg8HNarphBdzrix4ErYGPocAkA..&t=/package/@vue/core/v/5.4.7
- https://paths.esm.dev/?p=AAMeJbiAwB4cnBTA5AcAom0g6wG6gFADoAM4JaAmgB0ChgrYjmjg65BJ7wYDbAk4Em1IijvoQCSYDgqJoADAICNMVg7JpahTq9lddgp4nBpwB6bikZMDAAC1AcarraXHEg4rVBdyUlEGDWwmQhZuPUF-UWFpcxArW3BnR0VXNA9vLA1pLX-QIE62w3ATYUkz5FggWQAA&t=/package/@vue/core/v/5.4.7 (more aliases)
Resolved conflicts in: - app/composables/usePackageRoute.ts: Combined getPackageRoute() helper with usePackageRoute() composable - app/components/PackageDependencies.vue: Kept vulnerability display with getPackageRoute() helper - app/pages/[[org]]/[name].vue: Used usePackageRoute() composable for route parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.