Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use conventional commits from release-please for changelog #183

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

lukekarrys
Copy link
Contributor

release-please already fetches the commits and parses them into
conventional commit objects, so we are able to reuse most of that
instead of fetching it from GitHub again. This also adds tests for the
changelog output.

This also refactors the node-workspace plugin to use the built-in
post processing hook to rewrite our workspace dep commits.

@lukekarrys lukekarrys marked this pull request as ready for review September 8, 2022 19:24
@lukekarrys lukekarrys requested a review from a team as a code owner September 8, 2022 19:24
@lukekarrys lukekarrys marked this pull request as draft September 8, 2022 19:25
@lukekarrys lukekarrys force-pushed the lk/changelog branch 2 times, most recently from 57e8cbc to 098417f Compare September 13, 2022 07:25
`release-please` already fetches the commits and parses them into
conventional commit objects, so we are able to reuse most of that
instead of fetching it from GitHub again. This also adds tests for the
changelog output.

This also removes the workspace-deps plugin in favor of extending the
builtin node-workspace plugin. This fixes the issue of workspaces
sometimes not getting the correct tag name and changelog title if they
were only bumped as part of a workspace dep.
@lukekarrys lukekarrys marked this pull request as ready for review September 13, 2022 07:29
Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will get to see this in action in this very repo once we merge this commit. Neat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants