Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only add release please workspace plugins to monorepos #175

Merged
merged 1 commit into from
Aug 31, 2022
Merged

fix: only add release please workspace plugins to monorepos #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,12 @@ const getConfig = async ({
const derived = {
isRoot,
isWorkspace: !isRoot,
// Some files are written to the base of a repo but will
// include configuration for all packages within a monorepo
// For these cases it is helpful to know if we are in a
// monorepo since template-oss might be used only for
// workspaces and not the root or vice versa.
isMono: (isRoot && workspaces.length > 0) || !isRoot,
// repo
repoDir: root,
repoFiles,
Expand Down
5 changes: 1 addition & 4 deletions lib/content/release-please-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
{
"separate-pull-requests": {{{del}}},
"plugins": [
"node-workspace",
"workspace-deps"
],
"plugins": {{#if isMono}}["node-workspace", "workspace-deps"]{{else}}{{{del}}}{{/if}},
"exclude-packages-from-root": true,
"group-pull-request-title-pattern": "chore: release ${version}",
"pull-request-title-pattern": "chore: release${component} ${version}",
Expand Down
4 changes: 0 additions & 4 deletions release-please-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
{
"plugins": [
"node-workspace",
"workspace-deps"
],
"changelog-sections": [
{
"type": "feat",
Expand Down
Loading