remove puka #22
Merged
remove puka #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruyadorno
approved these changes
Mar 9, 2021
PR-URL: #22 Credit: @nlf Close: #22 Reviewed-by: @ruyadorno
ruyadorno
force-pushed
the
nlf/no-more-puka
branch
from
01c15c3 to
eeeb3f4
Compare
This was referenced Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding puka as a dependency here was an effort to make scripts defined in your package.json run in a more cross-platform compatible way, unfortunately the side effects seem to be largely undesirable.
as this is implemented today, things like expanding
%Path%style environment variables is impossible, passing""as a parameter gets lost entirely, and there are some inconsistencies in the way arguments are handled in different shells.removing puka is a step toward being consistent instead of trying to make a script written for unix work in windows, which IMO is where our focus should lie (consistency).
References
Fixes npm/cli#2731
Fixes #19