Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node-gyp to v.8.0.0 to prevent deprecation errors #25

Closed
silkfire opened this issue Apr 7, 2021 · 2 comments
Closed

Upgrade node-gyp to v.8.0.0 to prevent deprecation errors #25

silkfire opened this issue Apr 7, 2021 · 2 comments

Comments

@silkfire
Copy link

silkfire commented Apr 7, 2021

npm/run-script currently uses an older version of node-gyp that in turn has a dependency on the deprecated package request. By upgrading to the newly released version 8.0.0 of node-gyp (which now uses fetch instead), we can get rid of many deprecation messages stemming from any packages dependent on run-script.

@wraithgar
Copy link
Member

Because our support contract in npm includes >=10, we can not update node-gyp to v 8 until we drop v10 support.

node-gyp@8 requires >= 10.12.0 of nodejs because it uses the recursive flag for mkdir:

https://github.com/nodejs/node-gyp/blob/5f1a06c50f3b0c3d292f64948f85a004cfcc5c87/lib/configure.js#L75

@hildjj
Copy link

hildjj commented Jun 25, 2021

node-gyp claims to support node >=10.12.0:

https://github.com/nodejs/node-gyp/blob/161c2353ef5b562f4acfb2fd77608fcbd0800fc0/package.json#L37

Seems like we could file a bug there to remove the use of the recursive flag for mkdir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants