npm ls should NOT return an exit code of 1 if it finds unmet peer dependencies

[apoorva-sriv]

Clone of npm/npm#17624 since that repo was archived
In particular, see this comment.

[ljharb]

It absolutely should return nonzero; unmet peer deps mean your entire dep graph is invalid.

[ljharb]

Then it's misnamed ¯\_(ツ)_/¯ that doesn't change that it's working how it's supposed to.

[apoorva-sriv]

Well, yes, I wanted to raise this discussion to change that behaviour. Maybe have two separate commands: one to just list the tree (without throwing an error if it's not well formed) and another to check the tree, because throwing an error means the list command itself failed, and that's not true, right?

[ljharb]

It is true - since its goal is to list the dependency graph, and that's not possible if it's invalid.

[apoorva-sriv]

OK, then can the info about the exit code be added to the npm ls documentation?

[ljharb]

That sounds like a great PR! I'm sure the npm team would appreciate it.