Repository navigation
fix: resolve the shell from a trusted PATH - #163
Open
JamieMagee wants to merge 5 commits into
Open
JamieMagee wants to merge 5 commits into
JamieMagee wants to merge 5 commits into
Conversation
shmam
previously approved these changes
Jul 16, 2026
martinrrm
reviewed
Jul 16, 2026
martinrrm
reviewed
Jul 17, 2026
martinrrm
previously approved these changes
Jul 20, 2026
martinrrm
previously approved these changes
Jul 20, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f8598c2f-ae72-44cb-82bb-79f9d88c001c
martinrrm
force-pushed
the
fix/shell-trusted-path
branch
from
October 12, 2026 20:22
603d57b to
b1fb451
Compare
martinrrm
approved these changes
Oct 12, 2026
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spawnWithShellpassed the bare shell name tospawn, which resolves it againstopts.env.PATH, so a caller that leads that PATH with an untrustednode_modules/.binlet a dependency'ssh/cmdbin shadow the shell. Resolve the shell from the ambientprocess.env.PATHinstead, with a fallback to the bare name.