This repository was archived by the owner on Aug 11, 2022. It is now read-only.
fetch-package-metadata,add-named: Unify package version selection #15205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage increased (+0.03%) to 85.769% when pulling d83ee74e17586911d4c2f59ed0c9b5a1218a7b2e on iarna/there-can-be-only-one into 190a658 on release-next. |
|
Add or repurpose some unit tests for the extracted function and this will be ready to go. Nice work! |
iarna
force-pushed
the
iarna/there-can-be-only-one
branch
from
d83ee74 to
b6c8a3f
Compare
|
Tests – and everything else – LGTM. 🐑🚀🔥 |
iarna
force-pushed
the
release-next
branch
7 times, most recently
from
20e7365 to
ff1f0bb
Compare
|
This was merged and released in 4.1.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supplants #10662.
Gives us a single source of truth when it comes to selecting which version to use when given a range specifier.