This repository was archived by the owner on Aug 11, 2022. It is now read-only.
Do not call magic license values SPDX expressions #11215
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkat
pushed a commit
that referenced
this pull request
Jan 28, 2016
iarna
pushed a commit
that referenced
this pull request
Jan 28, 2016
PR-URL: #11215 Credit: @kemitchell Reviewed-By: @iarna
|
This was merged and included in npm@3.7.0 and npm@2.14.17. Thanks! |
|
Thank _you_, Kat! All my best to the team.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tiny PR corrects a false statement in the
licensesection of thepackage.jsondoc page.I must have missed this when we introduced the
SEE LICENSE IN <file>magic value forlicense. The doc page says that such string values are valid SPDX expressions. They aren't. Rather, they're npm-specific magic values.