Skip to content

fix: add missing 'use strict' directives #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintrc.local.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ module.exports = {
},
],
'import/no-nodejs-modules': ['error'],
strict: ['error', 'global'],
},
},
],
Expand Down
2 changes: 2 additions & 0 deletions benchmarks/bench-compare.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const Benchmark = require('benchmark')
const SemVer = require('../classes/semver')
const suite = new Benchmark.Suite()
Expand Down
2 changes: 2 additions & 0 deletions benchmarks/bench-diff.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const Benchmark = require('benchmark')
const diff = require('../functions/diff')
const suite = new Benchmark.Suite()
Expand Down
2 changes: 2 additions & 0 deletions benchmarks/bench-parse-options.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const Benchmark = require('benchmark')
const parseOptions = require('../internal/parse-options')
const suite = new Benchmark.Suite()
Expand Down
2 changes: 2 additions & 0 deletions benchmarks/bench-parse.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const Benchmark = require('benchmark')
const parse = require('../functions/parse')
const { MAX_SAFE_INTEGER } = require('../internal/constants')
Expand Down
2 changes: 2 additions & 0 deletions benchmarks/bench-satisfies.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const Benchmark = require('benchmark')
const satisfies = require('../functions/satisfies')
const suite = new Benchmark.Suite()
Expand Down
2 changes: 2 additions & 0 deletions benchmarks/bench-subset.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const Benchmark = require('benchmark')
const subset = require('../ranges/subset')
const suite = new Benchmark.Suite()
Expand Down
2 changes: 2 additions & 0 deletions bin/semver.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// Exits successfully and prints matching version(s) if
// any supplied version is valid and passes all tests.

'use strict'

const argv = process.argv.slice(2)

let versions = []
Expand Down
2 changes: 2 additions & 0 deletions classes/comparator.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const ANY = Symbol('SemVer ANY')
// hoisted class for cyclic dependency
class Comparator {
Expand Down
2 changes: 2 additions & 0 deletions classes/index.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

module.exports = {
SemVer: require('./semver.js'),
Range: require('./range.js'),
Expand Down
2 changes: 2 additions & 0 deletions classes/range.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const SPACE_CHARACTERS = /\s+/g

// hoisted class for cyclic dependency
Expand Down
2 changes: 2 additions & 0 deletions classes/semver.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const debug = require('../internal/debug')
const { MAX_LENGTH, MAX_SAFE_INTEGER } = require('../internal/constants')
const { safeRe: re, safeSrc: src, t } = require('../internal/re')
Expand Down
2 changes: 2 additions & 0 deletions functions/clean.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const parse = require('./parse')
const clean = (version, options) => {
const s = parse(version.trim().replace(/^[=v]+/, ''), options)
Expand Down
2 changes: 2 additions & 0 deletions functions/cmp.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const eq = require('./eq')
const neq = require('./neq')
const gt = require('./gt')
Expand Down
2 changes: 2 additions & 0 deletions functions/coerce.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const SemVer = require('../classes/semver')
const parse = require('./parse')
const { safeRe: re, t } = require('../internal/re')
Expand Down
2 changes: 2 additions & 0 deletions functions/compare-build.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const SemVer = require('../classes/semver')
const compareBuild = (a, b, loose) => {
const versionA = new SemVer(a, loose)
Expand Down
2 changes: 2 additions & 0 deletions functions/compare-loose.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const compare = require('./compare')
const compareLoose = (a, b) => compare(a, b, true)
module.exports = compareLoose
2 changes: 2 additions & 0 deletions functions/compare.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const SemVer = require('../classes/semver')
const compare = (a, b, loose) =>
new SemVer(a, loose).compare(new SemVer(b, loose))
Expand Down
2 changes: 2 additions & 0 deletions functions/diff.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const parse = require('./parse.js')

const diff = (version1, version2) => {
Expand Down
2 changes: 2 additions & 0 deletions functions/eq.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const compare = require('./compare')
const eq = (a, b, loose) => compare(a, b, loose) === 0
module.exports = eq
2 changes: 2 additions & 0 deletions functions/gt.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const compare = require('./compare')
const gt = (a, b, loose) => compare(a, b, loose) > 0
module.exports = gt
2 changes: 2 additions & 0 deletions functions/gte.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const compare = require('./compare')
const gte = (a, b, loose) => compare(a, b, loose) >= 0
module.exports = gte
2 changes: 2 additions & 0 deletions functions/inc.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const SemVer = require('../classes/semver')

const inc = (version, release, options, identifier, identifierBase) => {
Expand Down
2 changes: 2 additions & 0 deletions functions/lt.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const compare = require('./compare')
const lt = (a, b, loose) => compare(a, b, loose) < 0
module.exports = lt
2 changes: 2 additions & 0 deletions functions/lte.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const compare = require('./compare')
const lte = (a, b, loose) => compare(a, b, loose) <= 0
module.exports = lte
2 changes: 2 additions & 0 deletions functions/major.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const SemVer = require('../classes/semver')
const major = (a, loose) => new SemVer(a, loose).major
module.exports = major
2 changes: 2 additions & 0 deletions functions/minor.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const SemVer = require('../classes/semver')
const minor = (a, loose) => new SemVer(a, loose).minor
module.exports = minor
2 changes: 2 additions & 0 deletions functions/neq.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const compare = require('./compare')
const neq = (a, b, loose) => compare(a, b, loose) !== 0
module.exports = neq
2 changes: 2 additions & 0 deletions functions/parse.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const SemVer = require('../classes/semver')
const parse = (version, options, throwErrors = false) => {
if (version instanceof SemVer) {
Expand Down
2 changes: 2 additions & 0 deletions functions/patch.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const SemVer = require('../classes/semver')
const patch = (a, loose) => new SemVer(a, loose).patch
module.exports = patch
2 changes: 2 additions & 0 deletions functions/prerelease.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const parse = require('./parse')
const prerelease = (version, options) => {
const parsed = parse(version, options)
Expand Down
2 changes: 2 additions & 0 deletions functions/rcompare.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const compare = require('./compare')
const rcompare = (a, b, loose) => compare(b, a, loose)
module.exports = rcompare
2 changes: 2 additions & 0 deletions functions/rsort.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const compareBuild = require('./compare-build')
const rsort = (list, loose) => list.sort((a, b) => compareBuild(b, a, loose))
module.exports = rsort
2 changes: 2 additions & 0 deletions functions/satisfies.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const Range = require('../classes/range')
const satisfies = (version, range, options) => {
try {
Expand Down
2 changes: 2 additions & 0 deletions functions/sort.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const compareBuild = require('./compare-build')
const sort = (list, loose) => list.sort((a, b) => compareBuild(a, b, loose))
module.exports = sort
2 changes: 2 additions & 0 deletions functions/valid.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const parse = require('./parse')
const valid = (version, options) => {
const v = parse(version, options)
Expand Down
2 changes: 2 additions & 0 deletions index.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

// just pre-load all the stuff that index.js lazily exports
const internalRe = require('./internal/re')
const constants = require('./internal/constants')
Expand Down
2 changes: 2 additions & 0 deletions internal/constants.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

// Note: this is the semver.org version of the spec that it implements
// Not necessarily the package version of this code.
const SEMVER_SPEC_VERSION = '2.0.0'
Expand Down
2 changes: 2 additions & 0 deletions internal/debug.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const debug = (
typeof process === 'object' &&
process.env &&
Expand Down
2 changes: 2 additions & 0 deletions internal/identifiers.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const numeric = /^[0-9]+$/
const compareIdentifiers = (a, b) => {
const anum = numeric.test(a)
Expand Down
2 changes: 2 additions & 0 deletions internal/lrucache.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

class LRUCache {
constructor () {
this.max = 1000
Expand Down
2 changes: 2 additions & 0 deletions internal/parse-options.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

// parse out just the options we care about
const looseOption = Object.freeze({ loose: true })
const emptyOpts = Object.freeze({ })
Expand Down
2 changes: 2 additions & 0 deletions internal/re.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const {
MAX_SAFE_COMPONENT_LENGTH,
MAX_SAFE_BUILD_LENGTH,
Expand Down
2 changes: 2 additions & 0 deletions map.js
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
'use strict'

module.exports = testFile => testFile.replace(/test\//, '')
2 changes: 2 additions & 0 deletions preload.js
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
'use strict'

// XXX remove in v8 or beyond
module.exports = require('./index.js')
2 changes: 2 additions & 0 deletions ranges/gtr.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

// Determine if version is greater than all the versions possible in the range.
const outside = require('./outside')
const gtr = (version, range, options) => outside(version, range, '>', options)
Expand Down
2 changes: 2 additions & 0 deletions ranges/intersects.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const Range = require('../classes/range')
const intersects = (r1, r2, options) => {
r1 = new Range(r1, options)
Expand Down
2 changes: 2 additions & 0 deletions ranges/ltr.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const outside = require('./outside')
// Determine if version is less than all the versions possible in the range
const ltr = (version, range, options) => outside(version, range, '<', options)
Expand Down
2 changes: 2 additions & 0 deletions ranges/max-satisfying.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const SemVer = require('../classes/semver')
const Range = require('../classes/range')

Expand Down
2 changes: 2 additions & 0 deletions ranges/min-satisfying.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const SemVer = require('../classes/semver')
const Range = require('../classes/range')
const minSatisfying = (versions, range, options) => {
Expand Down
2 changes: 2 additions & 0 deletions ranges/min-version.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const SemVer = require('../classes/semver')
const Range = require('../classes/range')
const gt = require('../functions/gt')
Expand Down
2 changes: 2 additions & 0 deletions ranges/outside.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const SemVer = require('../classes/semver')
const Comparator = require('../classes/comparator')
const { ANY } = Comparator
Expand Down
2 changes: 2 additions & 0 deletions ranges/simplify.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

// given a set of versions and a range, create a "simplified" range
// that includes the same versions that the original range does
// If the original range is shorter than the simplified one, return that.
Expand Down
2 changes: 2 additions & 0 deletions ranges/subset.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const Range = require('../classes/range.js')
const Comparator = require('../classes/comparator.js')
const { ANY } = Comparator
Expand Down
2 changes: 2 additions & 0 deletions ranges/to-comparators.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const Range = require('../classes/range')

// Mostly just for testing and legacy API reasons
Expand Down
2 changes: 2 additions & 0 deletions ranges/valid.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const Range = require('../classes/range')
const validRange = (range, options) => {
try {
Expand Down
1 change: 1 addition & 0 deletions test/bin/semver.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
'use strict'

const t = require('tap')

const thisVersion = require('../../package.json').version
Expand Down
2 changes: 2 additions & 0 deletions test/classes/comparator.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const { test } = require('tap')
const Comparator = require('../../classes/comparator')
const comparatorIntersection = require('../fixtures/comparator-intersection.js')
Expand Down
2 changes: 2 additions & 0 deletions test/classes/index.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const t = require('tap')
t.same(require('../../classes'), {
SemVer: require('../../classes/semver'),
Expand Down
2 changes: 2 additions & 0 deletions test/classes/range.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const { test } = require('tap')
const Range = require('../../classes/range')
const Comparator = require('../../classes/comparator')
Expand Down
2 changes: 2 additions & 0 deletions test/classes/semver.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

const { test } = require('tap')
const SemVer = require('../../classes/semver')
const increments = require('../fixtures/increments.js')
Expand Down
2 changes: 2 additions & 0 deletions test/fixtures/comparator-intersection.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

// c0, c1, expected intersection, includePrerelease
module.exports = [
// One is a Version
Expand Down
2 changes: 2 additions & 0 deletions test/fixtures/comparisons.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

// [version1, version2]
// version1 should be greater than version2
// used by the cmp, eq, gt, lt, and neq tests
Expand Down
2 changes: 2 additions & 0 deletions test/fixtures/equality.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

// [version1, version2]
// version1 should be equivalent to version2
module.exports = [
Expand Down
2 changes: 2 additions & 0 deletions test/fixtures/increments.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

// [version, inc, result, options, identifier, identifierBase]
// inc(version, inc, options, identifier, identifierBase) -> result
module.exports = [
Expand Down
2 changes: 2 additions & 0 deletions test/fixtures/invalid-versions.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict'

// none of these are semvers
// [value, reason, opt]
const { MAX_LENGTH, MAX_SAFE_INTEGER } = require('../../internal/constants')
Expand Down
Loading
Loading