environment variables should be quoted in upstart scripts

[ceejbot]

To reproduce:

Create a service.json with an env stanza that looks like this:

"env": { "MY_VAR": "i am a string with a lot of spaces in it" }

Generate upstart configs in an ubuntu environment. Observe that the service is invoked as something like this:

PORT=8080 MY_VAR=i am a string with a lot of spaces in it /usr/bin/nodejs server.js

Sadness ensues.

[bcoe]

👍 will try to get this patched ASAP. as a work around, I think you could make your variable look like this:

"env": { "MY_VAR": "'i am a string with a lot of spaces in it'" }

silly though.

[rockbot]

@bcoe if we're cool with this underscore work-around for now, I'd like to just go ahead and merge it in so we can redeploy to staging/preview :-)