Enhance security recommendations for trusted publishers #1703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
p-
reviewed
Sep 1, 2025
There was a problem hiding this comment.
@leobalter I've added some comments - Feel free to ignore. 😉
content/packages-and-modules/securing-your-code/trusted-publishers.mdx
Outdated
Show resolved
Hide resolved
| 2. Select **"Require two-factor authentication and disallow tokens"** | ||
| 3. Save your changes | ||
|
|
||
| This configuration: |
There was a problem hiding this comment.
I'm not sure if this section is needed, I like the one below better (and think it's enough)
content/packages-and-modules/securing-your-code/trusted-publishers.mdx
Outdated
Show resolved
Hide resolved
leobalter
temporarily deployed
to
github-pages
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the security recommendations in the npm trusted publishers documentation by adding explicit guidance on restricting traditional token access when using OIDC-based publishing.
- Adds a dedicated section recommending disallowing non-OIDC tokens for maximum security
- Provides step-by-step instructions for configuring the "disallow tokens" setting
- Includes migration guidance for transitioning from token-based to trusted publishing
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
content/packages-and-modules/securing-your-code/trusted-publishers.mdx
Outdated
Show resolved
Hide resolved
leobalter
temporarily deployed
to
github-pages
GitHub Actions
Inactive
leobalter
temporarily deployed
to
github-pages
GitHub Actions
Inactive
…hers.mdx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…hers.mdx Co-authored-by: Peter Stöckli <p-@github.com>
…hers.mdx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
leobalter
force-pushed
the
leobalter-patch-1
branch
from
bf1d07c to
d898c61
Compare
|
fixed lint issues and rebased the branch. |
leobalter
had a problem deploying
to
github-pages
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve OIDC docs recommending disallowing non-OIDC tokens.
References