-
Couldn't load subscription status.
- Fork 3.8k
chore: test consolidation #8675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this should not fix the tests!!!
Everything that calls this already checks that flag in the node being passed in
#8540 removed the bad tests that were hooking into this!
| } | ||
| // normalize trailing slash | ||
| const registry = options.registry || 'https://registry.npmjs.org' | ||
| options.registry = this.registry = registry.replace(/\/+$/, '') + '/' |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
This that depends on may run slow on strings with many repetitions of '/'.
This that depends on may run slow on strings with many repetitions of '/'.
This that depends on may run slow on strings with many repetitions of '/'.
This that depends on may run slow on strings with many repetitions of '/'.
regular expression
Error loading related location
Loading library input
Error loading related location
Loading This
regular expression
Error loading related location
Loading library input
Error loading related location
Loading This
regular expression
Error loading related location
Loading library input
Error loading related location
Loading This
regular expression
Error loading related location
Loading library input
Error loading related location
Loading |
We'll have to break this up to see where those yaml warnings come from. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #7237. The eventual goal is to remove the mixin approach, as its original goals are no longer being met.
this.#resolveLinksmethods. There was one in build-ideal-tree and one in load-virtual, each one doing different things. There was no overlap in logic.#linkFromSpec. The function is not expecting a fourth parameterThere are a lot of small changes here, broken up into individual commits for easier review if needed. We'll squash to land it though.