fix: skip redacting URLs printed to console when browser not available #8587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jolyndenning
changed the title
owlstronaut
requested changes
Sep 23, 2025
| const skipRedact = args.length > 0 ? args[args.length - 1]?.skipRedact : false | ||
| if (skipRedact) { | ||
| args = args.slice(0, args.length - 1) | ||
| } |
There was a problem hiding this comment.
@jolyndenning this feels fragile to me. I think we should be able to use the established META pattern - see withMeta. We should be able to avoid this argument parsing
|
META implementation at #8614 |
wraithgar
added a commit
that referenced
this pull request
Sep 30, 2025
Login urls have tokens in them and need to be shown to the user on stdout, especially if they have no browser and need to copy/paste. This builds off of #8587 and changes things to use proc-log's META notation, which is how this kind of info is sent. --------- Co-authored-by: Jolyn <jolyndenning@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a browser is not installed, URLs for logging in and publishing are printed to the console. Since #8529, those URLs are now redacted, which is a breaking behavior.
The implementation in this pull request allows for any code going through
proc-logto skip redaction of the messageReferences
Fixes #8575