Skip to content

fix: change error to warning when canceling npm login or adduser #8344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

mbtools
Copy link
Contributor

@mbtools mbtools commented Jun 3, 2025

Problem

Canceling npm login or npm adduser leads to an error message:

image

image

Solution

npm now issues a simple warning (same as for npm init):

image

image

image

@mbtools mbtools requested a review from a team as a code owner June 3, 2025 22:40
@mbtools mbtools changed the title fix: change error to warning when canceling login or adduser fix: change error to warning when canceling npm login or adduser Jun 4, 2025
@wraithgar
Copy link
Member

Is it appropriate that the exit code of npm is now 0 instead of 1 on this use case?

@mbtools
Copy link
Contributor Author

mbtools commented Jun 12, 2025

Good for user, no good for automation. 👎

@mbtools mbtools closed this Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants