fix(powershell): don't use Invoke-Expression if ExpectingInput#8303
Closed
alexsch01 wants to merge 8 commits intonpm:latestfrom
alexsch01:latest
Closed
fix(powershell): don't use Invoke-Expression if ExpectingInput#8303alexsch01 wants to merge 8 commits intonpm:latestfrom alexsch01:latest
ExpectingInput#8303alexsch01 wants to merge 8 commits intonpm:latestfrom
alexsch01:latest
Conversation
This was referenced May 16, 2025
Contributor
Author
|
Would be great to make it into 11.4.1 |
Merged
Contributor
Author
|
I was going to add a warning for the |
Contributor
Author
|
Converting to a draft because it's missing some features |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dang, my apologies for getting this out after the npm release
this prevents a performance/security regression with piping strings into npm/npx
This should block nodejs/node#58347
This is the best compromise between convenience and security