fix: omit name from package-lock.json in case of package.json don't have name#8193
Draft
kchindam-infy wants to merge 2 commits intonpm:latestfrom
Draft
fix: omit name from package-lock.json in case of package.json don't have name#8193kchindam-infy wants to merge 2 commits intonpm:latestfrom
kchindam-infy wants to merge 2 commits intonpm:latestfrom
Conversation
owlstronaut
force-pushed
the
latest
branch
2 times, most recently
from
85ec0c9 to
26b6454
Compare
kchindam-infy
changed the title
kchindam-infy
changed the title
kchindam-infy
changed the title
Author
|
While name is not available in package.json, packag-lock.json inherits name of the directory which results in changes in package-lock.json each time when someone use the repo with different name which don't have any actual changes. To resolve it we can omit name from package-lock.json in case of no name available in package.json. This PR enhances the omission of the 'name' field from the package-lock.json when the package.json does not include a 'name'. This changes ensures consistency and avoids unnecessary data in the lock file. Passes all the test cases References
|
wraithgar
changed the title
Contributor
|
i like it 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References