Skip to content

fix(libnpmexec): fix bug not install latest pkg #4929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2022
Merged

fix(libnpmexec): fix bug not install latest pkg #4929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e255593
fix(libnpmexec): fix bug not install latest pkg
jihunleekr May 22, 2022
f68ef8e
chore: simplify code
jihunleekr May 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion workspaces/libnpmexec/lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ const exec = async (opts) => {
const add = manis
.filter(mani => !mani[_localManifest])
.filter(filterMissingPackagesFromInstallDir)
.map(mani => mani._from)
.map(mani => mani._id || mani._from)
.sort((a, b) => a.localeCompare(b, 'en'))

// no need to install if already present
Expand Down
2 changes: 1 addition & 1 deletion workspaces/libnpmexec/test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -657,7 +657,7 @@ t.test('no prompt if CI, multiple packages', async t => {
warn (title, msg) {
t.equal(title, 'exec', 'should warn exec title')
const expected = 'The following packages were not found and will be ' +
'installed: @ruyadorno/create-index, @ruyadorno/create-test'
'installed: @ruyadorno/create-index@1.0.0, @ruyadorno/create-test@1.0.0'
t.equal(msg, expected, 'should warn installing pkg')
},
},
Expand Down