feat(config): add more npm/node information to config ls#4723
Merged
Conversation
Contributor
|
no statistically significant performance changes detected timing results
|
ljharb
approved these changes
Apr 10, 2022
Contributor
Author
I would be in favor of that (or refactoring |
wraithgar
reviewed
Apr 11, 2022
wraithgar
approved these changes
Apr 13, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm config lshas become helpful to ask users to post the output of in bug reports. This adds the npm __dirname, npm version, and node version. These aren't really "config" items but we already haveprocess.execPathin there and I think these are as important as that.I want to be mindful of making this have too much output, but these additions feel like a positive tradeoff to me.