fix: resolve workspace paths from cwd when possible #4265
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these are changes that are required along with landing and publishing npm/config#28 (and updating it here) to enable automatic detection of a workspace root.
this fix stands on its own, however. if a user had the structure
and they ran
npm test -w ./a
from within/workspaces/
, they would currently get an error. this corrects that behavior so we resolve the path fora
based onprocess.cwd()
instead of the workspace root.the above comment is not directly related to this pull request, but i wanted to keep it here for posterity