fix(unpublish): Show warning when last version is being removed#4191
Merged
nlf merged 1 commit intonpm:release-nextfrom Jan 6, 2022
ebsaral:latest
Merged
fix(unpublish): Show warning when last version is being removed#4191nlf merged 1 commit intonpm:release-nextfrom ebsaral:latest
nlf merged 1 commit intonpm:release-nextfrom
ebsaral:latest
Conversation
ebsaral
changed the title
ebsaral
changed the title
|
Please implement this |
wraithgar
reviewed
Jan 4, 2022
Contributor
Author
|
The printed lines are getting mixed up in the console, when I tried it. Removing the carriage return fixed it for me.
If that’s not the case for others, I can revert it back.
… On 4. Jan 2022, at 20:09, Gar ***@***.***> wrote:
@wraithgar commented on this pull request.
In lib/commands/unpublish.js:
> @@ -71,7 +83,7 @@ class Unpublish extends BaseCommand {
if ((!spec || !spec.rawSpec) && !force) {
throw this.usageError(
- 'Refusing to delete entire project.\n' +
Was there a compelling reason to remove this carriage return??
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
ebsaral
changed the title
ebsaral
changed the title
wraithgar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
When we use
npm unpublishcommand with the last version of a package, we don't get a warning and we can't republish until 24 hours pass.Solution:
I wanted to give a warning to the user and force them to use
--forceif they are really sure about this action.Fixes npm/rfcs#355