Skip to content

fix(deprecate): add undeprecate support #3484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wraithgar merged 1 commit into from
Jun 30, 2021
Merged

fix(deprecate): add undeprecate support #3484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/deprecate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ class Deprecate extends BaseCommand {
}

async deprecate ([pkg, msg]) {
if (!pkg || !msg)
// msg == null becase '' is a valid value, it indicates undeprecate
if (!pkg || msg == null)
throw this.usageError()

// fetch the data and make sure it exists.
Expand Down
15 changes: 15 additions & 0 deletions test/lib/deprecate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,21 @@ t.test('invalid semver range', t => {
})
})

t.test('undeprecate', t => {
deprecate.exec(['foo', ''], (err) => {
if (err)
throw err
t.match(npmFetchBody, {
versions: {
'1.0.0': { deprecated: '' },
'1.0.1': { deprecated: '' },
'1.0.1-pre': { deprecated: '' },
},
}, 'undeprecates everything')
t.end()
})
})

t.test('deprecates given range', t => {
t.teardown(() => {
npmFetchBody = null
Expand Down