Skip to content

fix(install): ignore auditLevel #2929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Fix Tracker "idealTree:inflate:" already exists
merged 1 commit into from
Mar 24, 2021
Merged

fix(install): ignore auditLevel #2929

merged 1 commit into from
Mar 24, 2021

Conversation

@wraithgar
Copy link
Member

npm install should not be affected by the auditLevel config, as the
results of audit do not change its exit status.

References

Closes #2715

@wraithgar wraithgar requested a review from a team as a code owner March 23, 2021 22:50
ljharb
ljharb approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay ty

@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes labels Mar 24, 2021
@wraithgar
fix(install): ignore auditLevel
0379eab 
`npm install` should not be affected by the `auditLevel` config, as the
results of audit do not change its exit status.

PR-URL: #2929
Credit: @wraithgar
Close: #2929
Reviewed-by: @ljharb, @ruyadorno
@wraithgar wraithgar force-pushed the gar/install-audit-level branch from 1200a1f to 0379eab Compare March 24, 2021 17:26
@wraithgar wraithgar merged commit 0379eab into release-next Mar 24, 2021
@wraithgar wraithgar mentioned this pull request Mar 24, 2021
Merged
@ruyadorno ruyadorno mentioned this pull request Mar 24, 2021
Closed
@wraithgar wraithgar deleted the gar/install-audit-level branch May 6, 2021 14:48
@MrBrain295 MrBrain295 mentioned this pull request Oct 29, 2023
Open
@varmakarthik12 varmakarthik12 mentioned this pull request Oct 29, 2023
Open
@CALISOULB CALISOULB mentioned this pull request Nov 30, 2023
Open
This was referenced Nov 30, 2023
Open
Open
@bumplzz69 bumplzz69 mentioned this pull request Nov 30, 2023
Open
@mtdev2 mtdev2 mentioned this pull request Nov 30, 2023
Open
@Bhanditz Bhanditz mentioned this pull request Nov 30, 2023
Open
@Theo13111 Theo13111 mentioned this pull request Nov 30, 2023
Open
@Billywildhig Billywildhig mentioned this pull request Nov 30, 2023
Open
@311821105 311821105 mentioned this pull request Nov 30, 2023
Open
@Billywildhig Billywildhig mentioned this pull request Dec 1, 2023
Open
@baby636 baby636 mentioned this pull request Dec 1, 2023
Open
@EMWickd EMWickd mentioned this pull request Dec 1, 2023
Open
@kingjay66 kingjay66 mentioned this pull request Dec 1, 2023
Open
@EMWickd EMWickd mentioned this pull request Dec 1, 2023
Open
@jackromo888 jackromo888 mentioned this pull request Dec 1, 2023
Open
@gutwrinch gutwrinch mentioned this pull request Dec 1, 2023
Merged
@leonardoadame leonardoadame mentioned this pull request Dec 2, 2023
Open
@311821105 311821105 mentioned this pull request Feb 11, 2024
Open
@CALISOULB CALISOULB mentioned this pull request Feb 11, 2024
Open
@EMWickd EMWickd mentioned this pull request Feb 11, 2024
Open
@LadyK-21 LadyK-21 mentioned this pull request Feb 11, 2024
Open
@Mary12jo33 Mary12jo33 mentioned this pull request Feb 11, 2024
Open
@adamlaska adamlaska mentioned this pull request Feb 11, 2024
Open
@f4lco0n f4lco0n mentioned this pull request Feb 11, 2024
Open
@hojatA1 hojatA1 mentioned this pull request Feb 11, 2024
Open
@soloinovator soloinovator mentioned this pull request Feb 11, 2024
Open
@EMWickd EMWickd mentioned this pull request Feb 11, 2024
Open
@Billywildhig Billywildhig mentioned this pull request Feb 11, 2024
Open
@hojatA1 hojatA1 mentioned this pull request Feb 12, 2024
Open
@Alfred182 Alfred182 mentioned this pull request Feb 12, 2024
Open
@311821105 311821105 mentioned this pull request Feb 12, 2024
Open
@Billywildhig Billywildhig mentioned this pull request Feb 12, 2024
Open
@kingjay66 kingjay66 mentioned this pull request Feb 12, 2024
Open
@nicholaschoi168 nicholaschoi168 mentioned this pull request Feb 12, 2024
Open
@Theo13111 Theo13111 mentioned this pull request Feb 12, 2024
Open
@TheManager73 TheManager73 mentioned this pull request Feb 12, 2024
Open
@jackromo888 jackromo888 mentioned this pull request Feb 12, 2024
Open
@mtdev2 mtdev2 mentioned this pull request May 20, 2024
Open
@baby636 baby636 mentioned this pull request May 21, 2024
Open
@bumplzz69 bumplzz69 mentioned this pull request May 21, 2024
Open
@Bhanditz Bhanditz mentioned this pull request May 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ljharb ljharb ljharb approved these changes

@ruyadorno ruyadorno ruyadorno approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wraithgar @ljharb @ruyadorno @darcyclarke